On Tue, Sep 01, 2015 at 10:45:22AM +0000, [email protected] wrote: > Module: openembedded-core.git > Branch: master > Commit: 8236d57439640a185c0226312cd4903a3ce2f53b > URL: > http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=8236d57439640a185c0226312cd4903a3ce2f53b > > Author: Alex Franco <[email protected]> > Date: Fri Aug 28 17:34:04 2015 -0500 > > Fix mode +st on TMPDIR when creating it > > A sanity check fails when TMPDIR has setuid, setgid set. It was > proposed to fix this on TMPDIR creation instead of failing with > a sanity test only. This patch handles removal of those special > bits (and additonally, the sticky bit) from BUILDDIR and TMPDIR > when these directories are created.
Can you explain why it's needed to remove them? I have tmp-glibc mounted as tmpfs: drwxrwxrwt 4 root jenkins 80 Sep 1 19:02 tmp-glibc and since this change all bitbake executions are failing with: NOTE: Started PRServer with DBfile: /home/jenkins/oe/world/shr-core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 43102, PID: 9220 ERROR: Execution of event handler 'check_sanity_eventhandler' failed Traceback (most recent call last): File "check_sanity_eventhandler(e)", line 6, in check_sanity_eventhandler(e=<bb.event.SanityCheck object at 0x3c76ad0>) File "sanity.bbclass", line 34, in check_sanity(sanity_data=<bb.data_smart.DataSmart object at 0x3c83890>) File "sanity.bbclass", line 157, in check_sanity_everybuild(status=<SanityStatus object at 0x3c83850>, d=<bb.data_smart.DataSmart object at 0x3c83890>) OSError: [Errno 1] Operation not permitted: '/home/jenkins/oe/world/shr-core/tmp-glibc' I can change the permissions manually, but I would like to know why is this needed and checked every time the bitbake is executed. Regards, > > [YOCTO #7669] > > Signed-off-by: Alex Franco <[email protected]> > Signed-off-by: Richard Purdie <[email protected]> > > --- > > meta/classes/sanity.bbclass | 5 +++++ > scripts/oe-setup-builddir | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index ef90fc8..2864318 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -686,6 +686,7 @@ def check_sanity_version_change(status, d): > status.addresult(check_not_nfs(tmpdir, "TMPDIR")) > > def check_sanity_everybuild(status, d): > + import os, stat > # Sanity tests which test the users environment so need to run at each > build (or are so cheap > # it makes sense to always run them. > > @@ -839,6 +840,10 @@ def check_sanity_everybuild(status, d): > status.addresult("Error, TMPDIR has changed location. You > need to either move it back to %s or rebuild\n" % saved_tmpdir) > else: > bb.utils.mkdirhier(tmpdir) > + # Remove setuid, setgid and sticky bits from TMPDIR > + os.chmod(tmpdir, os.stat(tmpdir).st_mode & ~ stat.S_ISUID) > + os.chmod(tmpdir, os.stat(tmpdir).st_mode & ~ stat.S_ISGID) > + os.chmod(tmpdir, os.stat(tmpdir).st_mode & ~ stat.S_ISVTX) > with open(checkfile, "w") as f: > f.write(tmpdir) > > diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir > index add0b50..f5b7e4e 100755 > --- a/scripts/oe-setup-builddir > +++ b/scripts/oe-setup-builddir > @@ -24,6 +24,7 @@ if [ -z "$BUILDDIR" ]; then > fi > > mkdir -p "$BUILDDIR/conf" > +chmod -R -st "$BUILDDIR" > > if [ ! -d "$BUILDDIR" ]; then > echo >&2 "Error: The builddir ($BUILDDIR) does not exist!" > > -- > _______________________________________________ > Openembedded-commits mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-commits -- Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
