Warning informing that chmod failed is better than fatal error preventing me to build anything in that setup with tmpfs.
On Wed, Sep 2, 2015 at 11:27 PM, Alex Franco < [email protected]> wrote: > Checking may be the better approach, as warning here would do little more > than what the current failure does (informing that chmod failed) > > Alex Franco > > > On 09/02/2015 01:25 PM, Martin Jansa wrote: > >> On Wed, Sep 02, 2015 at 06:51:23PM +0100, Richard Purdie wrote: >> >>> On Wed, 2015-09-02 at 11:36 -0500, Alex Franco wrote: >>> >>>> Removing recursive option from chmod -st on BUILDDIR as it would >>>> take very long on existing build directories >>>> >>>> [YOCTO 7669] >>>> >>>> Signed-off-by: Alex Franco <[email protected]> >>>> --- >>>> scripts/oe-setup-builddir | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir >>>> index f5b7e4e..44c7dcc 100755 >>>> --- a/scripts/oe-setup-builddir >>>> +++ b/scripts/oe-setup-builddir >>>> @@ -24,7 +24,7 @@ if [ -z "$BUILDDIR" ]; then >>>> fi >>>> mkdir -p "$BUILDDIR/conf" >>>> -chmod -R -st "$BUILDDIR" >>>> +chmod -st "$BUILDDIR" >>>> >>> I think you did this so that conf/ gets the right permissions too. >>> Perhaps the best approach is: >>> >>> +chmod -st "$BUILDDIR" $BUILDDIR/conf" >>> >> Can we add "|| bbwarn foo" >> >> for cases when it doesn't work for whatever reason or check the >> permissions of these 2 dirs before calling chmod? >> >> ? >>> >>> Cheers, >>> >>> Richard >>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> [email protected] >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >> >
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
