On Tue, Sep 15, 2015 at 08:13:26AM -0700, Khem Raj wrote: > On Mon, Sep 14, 2015 at 11:33 PM, <[email protected]> wrote: > > On Mon, Sep 14, 2015 at 04:31:17PM +0000, Khem Raj wrote: > >> The code is creating more abstract types which is nice however it should > >> be using standard defines from stdint.h and not random defines to base > >> its own type system > > > > These types are not random. They are standard Linux kernel types used by > > headers > > exported to userspace and their definitions come from <linux/types.h>. > > These headers should not depend on libc headers like stdint.h. > > Right they are not random in general but they are randomly being > redefined by the application, > if it should be using linux/types.h those are different types than > what is being defined here. I have just > made the semantics of existing logic to be more c99 compliant. > > > > > Also, this file is actually a convenience copy of <linux/wireless.h> which > > should > > be used directly instead. > > There must be a reason to make own copy. May be hostap-utils want to > be portable to more than linux
A private copy of <linux/wireless.h> is only usefull with Linux kernel. Since mid 2000's Linux kernel has a way to properly export these headers to userspace. Thus the private copies should not be needed anymore. -Mikko -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
