On Tue, Oct 13, 2015 at 11:22:47AM -0400, Matt Porter wrote:
> On Tue, Oct 13, 2015 at 05:19:25PM +0200, Martin Jansa wrote:
> > On Tue, Oct 13, 2015 at 11:13:31AM -0400, Matt Porter wrote:
> > > The fbcon video backend is always disabled. Use the fbdev distro
> > > feature flag to enable/disable the fbcon video backend.
> > > 
> > > Signed-off-by: Matt Porter <[email protected]>
> > > Reviewed-by: Tom Rini <[email protected]>
> > > ---
> > >  meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb 
> > > b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> > > index c0d5c6a..c604c6a 100644
> > > --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> > > +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> > > @@ -13,6 +13,7 @@ LIC_FILES_CHKSUM = 
> > > "file://COPYING;md5=27818cd7fd83877a8e3ef82b82798ef4"
> > >  PROVIDES = "virtual/libsdl"
> > 
> > Can we please use PACKAGECONFIG here?
> 
> I noticed that libsdl2 does so, but stuck with the status quo below
> for addressing this. So, if I understand correctly you'd like it
> to be converted to be like the libsdl2 recipe, yes?

yes, I don't see any other recipe using fbdev as DISTRO_FEATURE, so
using it in PACKAGECONFIG would make it easier to enable/disable this.

Converting other options currently using DISTRO_FEATURES isn't a must,
but it would be nice to convert them as well.

> 
> -Matt
> 
> > >  DEPENDS = "${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 
> > > 'directfb', '', d)} \
> > > +    ${@bb.utils.contains('DISTRO_FEATURES', 'fbdev', 'fbdev', '', d)} \
> > >             ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
> > > 'virtual/libgl', '', d)} \
> > >             ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 
> > > 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
> > >             ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 
> > > 'libglu', '', d)} \
> > > @@ -40,10 +41,11 @@ EXTRA_OECONF = "--disable-static --enable-cdrom 
> > > --enable-threads --enable-timers
> > >                  --enable-file --disable-oss --disable-esd --disable-arts 
> > > \
> > >                  --disable-diskaudio --disable-nas --disable-esd-shared 
> > > --disable-esdtest \
> > >                  --disable-mintaudio --disable-nasm --disable-video-dga \
> > > -                --disable-video-fbcon --disable-video-ps2gs 
> > > --disable-video-ps3 \
> > > +                --disable-video-ps2gs --disable-video-ps3 \
> > >                  --disable-xbios --disable-gem --disable-video-dummy \
> > >                  --enable-input-events --enable-input-tslib 
> > > --enable-pthreads \
> > >                  ${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 
> > > '--enable-video-directfb', '--disable-video-directfb', d)} \
> > > +         ${@bb.utils.contains('DISTRO_FEATURES', 'fbdev', 
> > > '--enable-video-fbcon', '--disable-video-fbcon', d)} \
> > >                  ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
> > > '--enable-video-opengl', '--disable-video-opengl', d)} \
> > >                  ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 
> > > '--enable-video-x11', '--disable-video-x11', d)} \
> > >                  --disable-video-svga \
> > > -- 
> > > 2.1.4
> > > 
> > > -- 
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > [email protected]
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > 
> > -- 
> > Martin 'JaMa' Jansa     jabber: [email protected]
> 
> 



-- 
Martin 'JaMa' Jansa     jabber: [email protected]

Attachment: signature.asc
Description: Digital signature

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to