OK, then you need to say that in the commit message rather than saying that you're fixing a missing import - it's an optimisation, rather than a fix.
Cheers, Paul On Tue, 02 Feb 2016 15:31:06 Aníbal Limón wrote: > Yes, but i think is better to import only the module that we need. :) > > On 02/02/2016 03:25 PM, Paul Eggleton wrote: > > On Tue, 02 Feb 2016 09:14:16 Aníbal Limón wrote: > >> From: Aníbal Limón <[email protected]> > >> > >> oeqa.runtime import is used in TestContext to get data fixtures > >> directory. > >> > >> Signed-off-by: Aníbal Limón <[email protected]> > >> --- > >> > >> meta/lib/oeqa/oetest.py | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/meta/lib/oeqa/oetest.py b/meta/lib/oeqa/oetest.py > >> index 28577ef..16705cc 100644 > >> --- a/meta/lib/oeqa/oetest.py > >> +++ b/meta/lib/oeqa/oetest.py > >> > >> @@ -18,7 +18,7 @@ except ImportError: > >> pass > >> > >> import logging > >> > >> -import oeqa > >> +import oeqa.runtime > >> > >> from oeqa.utils.decorators import LogResults, gettag, getResults > >> > >> logger = logging.getLogger("BitBake") > > > > Are you sure this actually does anything? Importing the parent module > > should already allow access to child modules, AIUI. > > > > Cheers, > > Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
