On Fri, 2016-02-12 at 13:10 +0000, Richard Purdie wrote: > On Fri, 2016-02-12 at 12:28 +0000, Joshua G Lock wrote: > > On Fri, 2016-02-12 at 14:15 +0200, Dmitry Rozhkov wrote: > > > man 5 os-release states that VERSION_ID is > > > > > > " > > > a lower-case string (mostly numeric, no spaces or other > > > characters outside of 0-9, a-z, ".", "_" and "-") > > > identifying the operating system version > > > " > > > > > > This becomes crucial when ClearLinux's software > > > update mechanism is integrated into builds, because > > > its client side ignores VERSION_ID's value if it > > > doesn't conform the definition. > > > > > > Signed-off-by: Dmitry Rozhkov <[email protected]> > > > > I think we probably want this change, but we will also need to > > change > > the default assignment of VERSION_ID to match the rules: > > > > "Variable assignment values must be enclosed in double or single > > quotes > > if they include spaces, semicolons or other special characters > > outside > > of A-Z, a-z, 0-9." > > > > By default VERSION_ID is assigned DISTRO_VERSION, which contains > > invalid characters for this field in both OE Core (defaultsetup > > distro > > uses "nodistro.0") and meta-yocto (poky distro uses something like > > "2.0+snapshot-${DATE}" during development and something like > > "1.8.1" > > on > > a release). > > > > Thoughts on changing these? > > nodistro.0 is ok isn't it?
It is yes, I wasn't paying enough attention earlier. > > We should probably manipulate the string when writing this, "+" -> "- > " > and "A-Z" -> "a-z"? That sounds like a good solution to me. Regards, Joshua -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
