On 03/29/2016 07:59 PM, Richard Purdie wrote:
On Tue, 2016-03-29 at 00:59 -0700, Robert Yang wrote:
Move the common code to image.bbclass and remove duplicated ones.
Whilst I do like the idea of this patch set, I don't like generic
functions called "populate", or adding EFI variables to image.bbclass
itself.
Thanks, I will update it.
I believe that some refactoring does make a lot of sense here but this
doesn't look right. The diffstats don't seem to suggest a large volume
of common code either (as yet).
The patch that removes the duplicated code is:
[OE-core] [PATCH 3/3] image-live.bbclass/image-vm.bbclass: remove duplicated
code
meta/classes/image-live.bbclass | 58 ++++++-----------------------------------
meta/classes/image-vm.bbclass | 51 +-----------------------------------
meta/classes/image.bbclass | 46 ++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 100 deletions(-)
It removes 45 lines, I will check whether we can do more on these bbclasses.
// Robert
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
