On Wed, 2016-03-30 at 17:56 +0000, Khem Raj wrote:
> +Subject: [PATCH] Use UINTPTR_MAX instead of __WORDSIZE
> +
> +Do not include sys/user.h since it conflicts with
> +pt_regs struct from kernel APIs in asm/ptrace.h
> +
> +Signed-off-by: Khem Raj <[email protected]>
This description (and the subject line of the commit) implies that you
are removing the include unconditionally. But actually, you are only
removing it for non-glibc platforms.
Also, the change itself seems slightly backwards since the ptrace
manpage suggests that <sys/user.h> is actually the right header to be
using for these definitions and possibly it's <asm/ptrace.h> that should
be eliminated. Maybe that's not feasible here but it would be nice if
the patch header explained why. And...
> -SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch \
> - file://0002-Include-limits.h-for-PATH_MAX.patch \
> - "
> +SRC_URI = "${SOURCEFORGE_MIRROR}/psmisc/psmisc-${PV}.tar.gz \
> + file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch \
> + file://0002-Include-limits.h-for-PATH_MAX.patch \
> + file://0001-Use-UINTPTR_MAX-instead-of-__WORDSIZE.patch \
> + "
... this change is not mentioned in the commit message. Why have you
added the tarball to SRC_URI directly (rather than letting the .inc do
that as it did before)?
p.
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
