On 04/11/2016 03:06 AM, Denys Dmytriyenko wrote:
On Sun, Apr 10, 2016 at 07:14:56AM -0700, Robert Yang wrote:
It mismatched such as qemux86 and qemux86-64 which was incorrect, for
example:
COMPATIBLE_MACHINE = "(qemux86)"

That will match qemux86 and qemux86-64 and is by design! It's a regular

I'm afraid no, please see my last reply, for others such as
MACHINE_OVERRIDES, they never design to work in such a way, so I don't
think that COMPATIBLE_MACHINE should work in this way. If you really
want to match more, I think that you can set it as "(qemux86.*)" or
something familiar.

expression, not an exact string match! There are plenty of recipes
(especially outside of oe-core) that depend on this behavior, so please don't
break it!

I checked oe-core, there isn't any wrong when set MACHINE to:
 "qemuarm"
 "qemuarm64"
 "qemumips"
 "qemumips64"
 "qemuppc"
 "qemux86"
 "qemux86-64"

and run bitbake world -g.

Would you please tell me which recipes outside of oe-core relay on this?
I think that we should fix the recipe.

// Robert



But it treated MACHINE = "qemux86-64" as matched. The similar to others.

This patch fixes the problem.

Signed-off-by: Robert Yang <[email protected]>
---
  meta/classes/base.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index f9697a9..f376478 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -469,7 +469,7 @@ python () {
          import re
          compat_machines = (d.getVar('MACHINEOVERRIDES', True) or 
"").split(":")
          for m in compat_machines:
-            if re.match(need_machine, m):
+            if re.match('^' + need_machine + '$', m):
                  break
          else:
              raise bb.parse.SkipPackage("incompatible with machine %s (not in 
COMPATIBLE_MACHINE)" % d.getVar('MACHINE', True))
--
2.8.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to