Hello Martin, Hello Richard, Martin, thanks for updating the patch to comply to Richard's suggestions.
On Tue, Apr 19, 2016 at 7:31 AM, Martin Jansa <[email protected]> wrote: > * add separate variable for configuration options generated from > PACKAGECONFIG setting, this helps other bbclasses and recipes > to take advantage of PACKAGECONFIG mechanism, without including > other options from EXTRA_OECONF > * e.g. meta-qt5 recipes are abusing EXTRA_OECONF to get options > from PACKAGECONFIG: > EXTRA_QMAKEVARS_PRE += > but with > conf/distro/include/no-static-libs.inc > it means getting --disable-static as invalid option inside > EXTRA_QMAKEVARS_PRE as reported by Alexandre Belloni who tried > to use poky with meta-qt5. > * once we migrate all bbclasses and recipes to PACKAGECONFIG_CONFARGS > we should also restrict EXTRA_OECONF append only to autotools.bbclass > like I did for cmake.bbclass > > Signed-off-by: Martin Jansa <[email protected]> Acked-by: Otavio Salvador <[email protected]> Richard, I understand we are late in the release cycle however this change is indeed required to fix our build of Qt5 using Poky distribution. The patch seems fairly safe and should have no impact for current metadata, while it allow for meta-qt5 to fix the Poky support. The patch has been sent on Feb and ended being forgotten in the merge queue however it is being used daily by the World Build test from Martin, which includes it so static libraries can be disabled. Please consider it for 2.1. Best Regards, -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
