Hi, On Fri, Aug 19, 2016 at 5:45 PM, Richard Purdie < [email protected]> wrote:
> On Fri, 2016-08-19 at 17:35 +0300, Ed Bartosh wrote: > > Recent renaming of COMPRESSIONTYPES variable can break recipes that > > still use it. Including value of COMPRESSIONTYPES variable into > > CONVERSIONTYPES should prevent this. > > > > Signed-off-by: Ed Bartosh <[email protected]> > > --- > > meta/classes/image_types.bbclass | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > Does this actually work? Won't COMPRESSION_CMD be unset in these cases > so it would just trigger further failures? > > Perhaps we should just error and tell the user if COMPRESSION_TYPES is > set (in sanity.bbclass?). > These lines were simply missing from 9d68c024790850cab72ead1e3372a5fcec4ef7b0 (the commit message talks about these lines). In Ostro we add a few custom conversions via COMPRESSIONTYPES_append and without this patch those types are not recognized and we hit: "No IMAGE_CMD defined for IMAGE_FSTYPES entry 'dsk.ova' - possibly invalid type name or missing support class" (ova is one of our COMPRESSIONTYPES). -- Mikko
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
