Hi everybody, Khem Raj <[email protected]> wrote:
>> On Aug 11, 2016, at 3:04 AM, Clemens Lang <[email protected]> >> wrote: >> >> Recipes that fetch from a single git source, assign a name to this >> source and do not set SRCREV_FORMAT to this name will always get >> a GITPKGV value of "default", which causes version-going-backwards QA >> errors. >> >> Fix this by automatically determining a suitable SRCREV_FORMAT from the >> SRC_URI if none is set explicitly. This code does not run for multiple >> git sources, because bitbake's fetcher enforces setting SRCREV_FORMAT >> when multiple version-controlled sources are used. > > looks good. > >> Signed-off-by: Clemens Lang <[email protected]> >> --- >> meta-oe/classes/gitpkgv.bbclass | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/meta-oe/classes/gitpkgv.bbclass >> b/meta-oe/classes/gitpkgv.bbclass >> index 1cba00c..f73304a 100644 >> --- a/meta-oe/classes/gitpkgv.bbclass >> +++ b/meta-oe/classes/gitpkgv.bbclass >> @@ -61,7 +61,14 @@ def get_git_pkgv(d, use_tags): >> # >> format = d.getVar('SRCREV_FORMAT', True) >> if not format: >> - format = 'default' >> + names = [] >> + for url in ud.values(): >> + if url.type == 'git' or url.type == 'gitsm': >> + names.extend(url.revisions.keys()) >> + if len(names) > 0: >> + format = '_'.join(names) >> + else: >> + format = 'default' >> >> found = False >> for url in ud.values(): >> — >> 2.8.1 Shameless bump. I haven’t heard any feedback on this other than this “looks good” comment, but it isn’t merged. Is there a problem with the patch? -- Clemens Lang • Development Specialist BMW Car IT GmbH • Lise-Meitner-Str. 14 • 89081 Ulm • http://bmw-carit.com ------------------------------------------------------------------------- BMW Car IT GmbH Geschäftsführer: Michael Würtenberger und Alexis Trolin Sitz und Registergericht: München HRB 134810 ------------------------------------------------------------------------- -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
