On Sat, Dec 10, 2016 at 3:40 AM, Robert P. J. Day <[email protected]> wrote: > > i've nattered about this before but not sure i ever got an answer -- > here's the last bit of core-image.bbclass: > > CORE_IMAGE_BASE_INSTALL = '\ > packagegroup-core-boot \ > packagegroup-base-extended \ > \ > ${CORE_IMAGE_EXTRA_INSTALL} \ > ' > > CORE_IMAGE_EXTRA_INSTALL ?= "" > > IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}" > > the first time i saw that (long ago), it took me a few looks to figure > out what was happening. can this not be written in a more obvious way: > > CORE_IMAGE_BASE_INSTALL = '\ > packagegroup-core-boot \ > packagegroup-base-extended \ > ' > > CORE_IMAGE_EXTRA_INSTALL ?= "" > > IMAGE_INSTALL ?= " \ > ${CORE_IMAGE_BASE_INSTALL} \ > ${CORE_IMAGE_EXTRA_INSTALL} \ > " > > is that not equivalent, or am i missing something? it's certainly > clearer as to what's happening if people are perusing the code.
They are same AFAICT, dont feel strongly about readability but feel free to send a patch -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
