On Wed, Dec 21, 2016 at 2:00 PM, Ed Bartosh <[email protected]> wrote: > On Tue, Dec 20, 2016 at 07:27:04PM +0100, Maciej Borzęcki wrote: >> On Tue, Dec 20, 2016 at 3:04 PM, Ed Bartosh <[email protected]> >> wrote: >> > On Mon, Dec 19, 2016 at 12:20:56PM +0100, Maciej Borzecki wrote: >> >> v6 of a patch series previously posted here [1]. >> >> >> >> Changes since v5: >> >> >> >> * `oe-selftest: enforce en_US.UTF-8 locale` was merged to master, hence >> >> it's no >> >> longer part of this series >> >> >> >> * rebased on top of master (d0d260b0b85790ceb136dd6b0445e8e33d038f5e) >> >> >> > >> > The patchset looks good to me. Thank you. >> > >> > Couple of questions: >> > - did you test if Lars' change >> > >> > https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=db08ffee0ad1451f3bf710f4d1b623938ba9aefb >> > works with your patchset? >> >> Yes. The series was rebased on top of >> d0d260b0b85790ceb136dd6b0445e8e33d038f5e, which includes Lars' patch. > > The series causes conflicts on the latest master. Can you check if it's > really the case or it's just something wrong with my setup?
Just rebased on top current master d41d2fd and pushed to https://github.com/bboozzoo/poky branch bboozzoo/wic-fixed-size-v7 in case you want to test locally. I guess the conflict was with patch aa1c50a `selftest/wic: extending test coverage for WIC script options`, which has been reverted yesterday by RP. Jair has posted a v2 yesterday and I expect it to be merged soon. So, I think I'll just wait a couple of days (actually more like until the beginning of January) before publishing a rebased version of my series. <snip> > >> >> I've run it on beaglebone, vexpress-qemu, qemux86 and qemuarm. Agree >> with your observation though. I think that at least these TCs could be >> made machine agnostic: >> >> - test_build_artifacts >> - test_build_image_name >> - test_compress_* >> - test_gpt_image >> - test_wic_image_type >> - test_wrong_compressor >> - test_rootfs_* >> >> > > Yes, that's exactly my point. We should make generic tests work on any > machine. > > Would you be willing to do this in a separate patchset together with > your oe-selftest core fixes? > > I'd suggest to only include new testcase that works on qemu-x86* into > this patchset. It will make it faster to get merged. > I would prefer to post these changes as a separate patchset. It looks like there's already a couple of potentially conflicting patches floating on the mailing list, so I would prefer to get --fixed-size merged before starting another one. Regards, -- Maciej Borzecki RnDity -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
