On 25/01/17 05:56, Richard Purdie wrote: > On Tue, 2017-01-24 at 11:52 -0700, Christopher Larson wrote: >> On Tue, Jan 24, 2017 at 1:37 AM, <[email protected]> >> wrote: >>> From: Mariano Lopez <[email protected]> >>> >>> opkg uses empty lines as separator for next package and if an ipk >>> file was packaged with empty lines in DESCRIPTION opkg won't be >>> able to handle such ipk file, this happens at execution time. >>> >>> This commit will add a check for empty lines in DESCRIPTION when >>> generating to ipk package to avoid this issue. >>> >>> [YOCTO #10677] >>> >>> Signed-off-by: Mariano Lopez <[email protected]> >>> >> Could it handle a line with just a space, or a period? Could you not >> replace the lines with that instead, rather than aborting? > FWIW package_deb uses ".".
Also opkg will strip() the lines, so an empty space is not a option here. > > Also, please use bb.fatal() calls with caution, I just removed several > from that class. In this case its perhaps ok but often the correct > thing to do is raise an exception of some kind. This means bitbake will > generate a usable traceback rather than simply printing the fatal > message. In this case the message is probably fine but there were > several cases where a traceback was a much better idea as the fatal > message wasn't enough to debug with. Fair enough, I will consider this advice when using bb.fatal() Regards, Mariano -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
