On Tue, 28 Mar 2017, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: openembedded-core-boun...@lists.openembedded.org > > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of > > Robert P. J. Day > > Sent: den 28 mars 2017 12:51 > > To: OE Core mailing list > > Subject: [OE-core] [PATCH] classes: Standardize strings tests, and join > > some if/then/while/do lines > > > > > > For better or worse, two types of cleanup in meta/classes directory: > > > > * Replace old-style 'x${VAR} = x' tests with -n/-z string tests > > * Unsplit lines to keep if/then, while/do on same line > > > > Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca> > > > > --- > > > > i realize there are two types of tidying here -- if that offends > > people, i can split it into two separate submissions. nothing here > > should affect execution, but it's always possible i screwed something > > up, not sure how to rigourously test these changes. > > > > also, when i did change a shell string test, i added {} around the > > variable name, it's just a standard i like for visual clarity. apply > > all or part of what seems useful. > > You should absolutely not do this, especially if you want visual clarity > in a BitBake recipe. This makes the variable look like a BitBake variable > instead of a shell variable, and not just to us humans, but to bitbake > as well...
yes, ross just pointed that out, i had totally forgotten about that. so scrap what i sent in earlier. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core