Hello,
Thank you for taking time and making the patch for Werror disablement.
I have already notified opencl-cts upstream about the warnings, made a
pull request which has been approved. Now waiting for the merge, once
that is merged, all warnings should be resolved without the need of
disabling -Werror.
Once my changes will be merged, they will be included in the next
release of openl-cts and I'll send new patches here editing the recipe
accordingly.
Regards,
Antonios
On 1/28/25 11:10 PM, Khem Raj wrote:
FWIW, I have tweaked your patch to add a CMake option to provide a
knob to allow disabling Werror, this is a good to have especially for
distributions, since they may not be interested in fixing warnings as
errors, while developers of this component
ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source
of this email and know the content is safe.
Report Suspicious
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!tDdkczggGK0zQgUO0v2psgSyQ8iN4-2htHmBpKsKI91RdSZ0HEd7IgSAqdzBMRqACMmOs-zI__9yVKsMYMHFOiW86Jt3ID38rqWvMPp95MnO7Iod29NLYwRoEvk$>
ZjQcmQRYFpfptBannerEnd
FWIW, I have tweaked your patch to add a CMake option to provide a
knob to allow disabling Werror, this is a good to have
especially for distributions, since they may not be interested in
fixing warnings as errors, while developers of this component
might be interested in enabling it.
Please submit this patch to opencl-cts upstream
On Tue, Jan 28, 2025 at 11:56 AM Khem Raj <[email protected]> wrote:
>
> autobuilder config is default poky setup, so unless you are using
> other distro options which might impact it, e.g. using clang compiler
> or not using security options.
>
> On Mon, Jan 27, 2025 at 2:14 PM Antonios Christidis <[email protected]>
wrote:
> >
> > Hello,
> >
> > I am not able to replace those errors on my end. Are there any
> > references describing the build environment of the auto builder? Hoping
> > to follow those and then be able to replicate those errors on my end.
> >
> > Side note: This is interesting, as in the logs I'm seeing
> > "[-Werror=maybe-uninitialized]" errors which my patch targeted to fix.
> >
> > Regards,
> >
> > Antonios
> >
> >
> > On 1/27/25 1:50 PM, Khem Raj wrote:
> > > fails with master here
> > > https: //urldefense. com/v3/__https: //autobuilder. yoctoproject.
org/valkyrie/*/builders/81/builds/320/steps/14/logs/stdio__;Iw!!G3vK!U1telv7G4EdWNd8Q7mT2lxwrfCEr8VY9ZJDDTdQDwd5SwarmDepPE58aL0--mucfFnOkooRNNbihy_k$
> > > cc1plus:
> > > ZjQcmQRYFpfptBannerStart
> > > This message was sent from outside of Texas Instruments.
> > > Do not click links or open attachments unless you recognize the source
> > > of this email and know the content is safe.
> > > Report Suspicious
> > >
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!tDdkczggGK0zQiXM8lsjUIw0foiJ4oL-lS26WbF22UijSS0Ba7zdDBO_8mMm1n2WN9uSVrZzguSdX1Wt-sbhjuKEJ9lw_kgnhg9nodQmtYJ2kfTSN9lkr0sCjv4$>
> > >
> > > ZjQcmQRYFpfptBannerEnd
> > > fails with master here
> > >
> > > https://urldefense.com/v3/__https://autobuilder.yoctoproject.org/valkyrie/*/builders/81/builds/320/steps/14/logs/stdio__;Iw!!G3vK!U1telv7G4EdWNd8Q7mT2lxwrfCEr8VY9ZJDDTdQDwd5SwarmDepPE58aL0--mucfFnOkooRNNbihy_k$
> <https://urldefense.com/v3/__https://autobuilder.yoctoproject.org/valkyrie/*/builders/81/builds/320/steps/14/logs/stdio__;Iw!!G3vK!U1telv7G4EdWNd8Q7mT2lxwrfCEr8VY9ZJDDTdQDwd5SwarmDepPE58aL0--mucfFnOkooRNNbihy_k$
>>> >
> > > cc1plus: error: '-Wformat-security' ignored without '-Wformat'
> > > [-Werror=format-security]
> > > | cc1plus: all warnings being treated as errors
> > >
> > > On Mon, Jan 27, 2025 at 6:55 AM <[email protected]> wrote:
> > > >
> > > > From: Antonios Christidis <[email protected]>
> > > >
> > > > This recipe provides the opecl-cts suite. This is a pre-release version
> > > > v2024-08-08, which I have tested to work with opencl-headers version
v2024.05.08
> > > > . The pre-release version was picked due to incompatibility issues with
other
> > > > versions of headers.
> > > >
> > > > The recipe also includes a patch, to allow it to compile and build
properly.
> > > > Further information below.
> > > >
> > > > Signed-off-by: Antonios Christidis <[email protected]>
> > > > ---
> > > > .../files/0001-Ignore-Compiler-Warnings.patch | 37 +++++++++++++++++++
> > > > .../opencl/opencl-cts_2024.08.08.bb | 26 +++++++++++++
> > > > 2 files changed, 63 insertions(+)
> > > > create mode 100644
meta-oe/recipes-core/opencl/files/0001-Ignore-Compiler-Warnings.patch
> > > > create mode 100644 meta-oe/recipes-core/opencl/opencl-cts_2024.08.08.bb
> > > >
> > > > diff --git
a/meta-oe/recipes-core/opencl/files/0001-Ignore-Compiler-Warnings.patch
b/meta-oe/recipes-core/opencl/files/0001-Ignore-Compiler-Warnings.patch
> > > > new file mode 100644
> > > > index 000000000..2515c7f16
> > > > --- /dev/null
> > > > +++
b/meta-oe/recipes-core/opencl/files/0001-Ignore-Compiler-Warnings.patch
> > > > @@ -0,0 +1,37 @@
> > > > +From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001
> > > > +From: Antonios Christidis <[email protected]>
> > > > +Date: Fri, 17 Jan 2025 15:05:39 -0600
> > > > +Subject: [PATCH] Ignore Compiler Warnings
> > > > +
> > > > +
> > > > +Within the cmake build system, the compiler -Werror flag is enabeled.
This
> > > > +turns all warnings into errors and doens't allow the system to compile
> > > > +correctly. Change the system to ignore the 3 warning rules that show
up when
> > > > +compiling.
> > > > +
> > > > +Upstream-Status: Inappropriate [oe specific - compilation errors due
to cross-compiling]
> > > > +
> > > > +Signed-off-by: Antonios Christidis <[email protected]>
> > > > +
> > > > +---
> > > > + CMakeLists.txt | 4 +++-
> > > > + 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > +
> > > > +diff --git a/CMakeLists.txt b/CMakeLists.txt
> > > > +index 5cfef6b3..71b6ddb4 100644
> > > > +--- a/CMakeLists.txt
> > > > ++++ b/CMakeLists.txt
> > > > +@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}"
MATCHES "(Apple)?Clang"
> > > > + add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning
directive
> > > > + add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785
> > > > + add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue
#784
> > > > +-
> > > > ++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized)
> > > > ++ add_cxx_flag_if_supported(-Wno-stringop-truncation)
> > > > ++ add_cxx_flag_if_supported(-Wno-strict-aliasing)
> > > > + # -msse -mfpmath=sse to force gcc to use sse for float math,
> > > > + # avoiding excess precision problems that cause tests like
int2float
> > > > + # to falsely fail. -ffloat-store also works, but WG suggested
> > > > +--
> > > > +2.34.1
> > > > +
> > > > diff --git a/meta-oe/recipes-core/opencl/opencl-cts_2024.08.08.bb
b/meta-oe/recipes-core/opencl/opencl-cts_2024.08.08.bb
> > > > new file mode 100644
> > > > index 000000000..f6f4e9466
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-core/opencl/opencl-cts_2024.08.08.bb
> > > > @@ -0,0 +1,26 @@
> > > > +SUMMARY = "OpenCL CTS"
> > > > +DESCRIPTION = "OpenCL CTS test suite"
> > > > +LICENSE = "Apache-2.0"
> > > > +LIC_FILES_CHKSUM =
"file://LICENSE.txt;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > > > +
> > > > +inherit pkgconfig cmake
> > > > +
> > > > +DEPENDS += "opencl-headers opencl-icd-loader"
> > > > +RDEPENDS:${PN} += "python3-core python3-io"
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +
> > > > +SRC_URI =
"git://github.com/KhronosGroup/OpenCL-CTS.git;protocol=https;branch=main;lfs=0 \
> > > > + file://0001-Ignore-Compiler-Warnings.patch"
> > > > +
> > > > +SRCREV = "a406b340913f622da089b00f284a597656c10239"
> > > > +
> > > > +EXTRA_OECMAKE:append = " -DCL_INCLUDE_DIR=${STAGING_INCDIR}
-DCL_LIB_DIR=${STAGING_LIBDIR} -DOPENCL_LIBRARIES=OpenCL"
> > > > +
> > > > +do_install() {
> > > > + install -d ${D}${bindir}/opencl_test_conformance
> > > > + cp -r ${B}/test_conformance/*
${D}${bindir}/opencl_test_conformance
> > > > + sed -i 's:/usr/bin/python:/usr/bin/python3:g'
${D}${bindir}/opencl_test_conformance/run_conformance.py
> > > > + find "${D}${bindir}/opencl_test_conformance" -name
cmake_install.cmake -type f -delete
> > > > + find "${D}${bindir}/opencl_test_conformance" -name CMakeFiles -type d
-exec rm -rf "{}" \; -depth
> > > > +}
> > > > --
> > > > 2.34.1
> > > >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#115138):
https://lists.openembedded.org/g/openembedded-devel/message/115138
Mute This Topic: https://lists.openembedded.org/mt/110839841/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
