On Mon, Feb 3, 2025 at 10:14 AM Marko, Peter <[email protected]> wrote: > > Test build with arm+clang was successful. > I hope that helps and remaining archs will be checked on autobuilder. > > Note that build with ptest enabled fails with clang in do_compile_ptest > during linking with absl, but the same happens without this patch, too.
Thanks for build testing, the CI builds are usually with ptest turned on, so if it fails with ptest enabled without this patch we should have been failing on CI > > Peter > > > -----Original Message----- > > From: Khem Raj <[email protected]> > > Sent: Monday, February 3, 2025 1:36 > > To: Marko, Peter (FT D EU SK BFS1) <[email protected]> > > Cc: [email protected] > > Subject: Re: [oe] [meta-oe][PATCH 1/8] protobuf: remove unneeded atomic > > linker > > flag > > > > On Sun, Feb 2, 2025 at 1:40 PM Peter Marko via lists.openembedded.org > > <[email protected]> wrote: > > > > > > From: Peter Marko <[email protected]> > > > > > > This is handled in protofuf cmake since 3.15: > > > > > https://github.com/protocolbuffers/protobuf/commit/55ed1d427ccc0d20092774 > > 6329ac9b811dee77b9 > > > > > > Signed-off-by: Peter Marko <[email protected]> > > > --- > > > meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb b/meta- > > oe/recipes-devtools/protobuf/protobuf_4.25.5.bb > > > index 89e1071b59..efd70d6474 100644 > > > --- a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb > > > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb > > > @@ -115,9 +115,3 @@ RDEPENDS:${PN}-ptest = "bash > > ${@bb.utils.contains('PACKAGECONFIG', 'python', 'py > > > MIPS_INSTRUCTION_SET = "mips" > > > > > > BBCLASSEXTEND = "native nativesdk" > > > - > > > -LDFLAGS:append:arm = " -latomic" > > > -LDFLAGS:append:mips = " -latomic" > > > -LDFLAGS:append:powerpc = " -latomic" > > > -LDFLAGS:append:mipsel = " -latomic" > > > -LDFLAGS:append:riscv32 = " -latomic" > > > > They were needed with clang IIRC, does it work without it now ? > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#115254): https://lists.openembedded.org/g/openembedded-devel/message/115254 Mute This Topic: https://lists.openembedded.org/mt/110959917/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
