On 11/10/25 16:17, Yoann Congal wrote:


Le lun. 10 nov. 2025 à 09:08, Yi Zhao <[email protected]> a écrit :


    On 11/10/25 15:55, Yoann Congal wrote:


    Le sam. 8 nov. 2025 à 15:18, Yi Zhao via lists.openembedded.org
    
<https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlNwcN40j7$>
    <[email protected]> a écrit :

        Add UPSTREAM_CHECK_URI and UPSTREAM_CHECK_REGEX to check the
        correct
        latest stable verison.

        Before the patch:
        $ devtool latest-version menulibre
        INFO: Current version: 2.4.0
        INFO: Latest version:

        After the patch:
        $ devtool latest-version menulibre
        INFO: Current version: 2.4.0
        INFO: Latest version: 2.4.0

        Signed-off-by: Yi Zhao <[email protected]>
        ---
         meta-xfce/recipes-apps/menulibre/menulibre_2.4.0.bb
        
<https://urldefense.com/v3/__http://menulibre_2.4.0.bb__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN81Wey67$>
        | 3 +++
         1 file changed, 3 insertions(+)

        diff --git
        a/meta-xfce/recipes-apps/menulibre/menulibre_2.4.0.bb
        
<https://urldefense.com/v3/__http://menulibre_2.4.0.bb__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN81Wey67$>
        b/meta-xfce/recipes-apps/menulibre/menulibre_2.4.0.bb
        
<https://urldefense.com/v3/__http://menulibre_2.4.0.bb__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN81Wey67$>
        index 71d3ab4d29..4c52249fed 100644
        --- a/meta-xfce/recipes-apps/menulibre/menulibre_2.4.0.bb
        
<https://urldefense.com/v3/__http://menulibre_2.4.0.bb__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN81Wey67$>
        +++ b/meta-xfce/recipes-apps/menulibre/menulibre_2.4.0.bb
        
<https://urldefense.com/v3/__http://menulibre_2.4.0.bb__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN81Wey67$>
        @@ -15,6 +15,9 @@ REQUIRED_DISTRO_FEATURES = "x11
        gobject-introspection-data"
         SRC_URI =
        
"https://github.com/bluesabre/${BPN}/releases/download/${BP}/${BP}.tar.gz
        
<https://urldefense.com/v3/__https://github.com/bluesabre/$*7BBPN*7D/releases/download/$*7BBP*7D/$*7BBP*7D.tar.gz__;JSUlJSUl!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN4rVMobI$>"
         SRC_URI[sha256sum] =
        "d906acf9cc13b0e15b8e342ae9aab8b0680db336a382d0c42f5d5f465f593c9f"

        +UPSTREAM_CHECK_URI =
        "https://github.com/bluesabre/menulibre/releases
        
<https://urldefense.com/v3/__https://github.com/bluesabre/menulibre/releases__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN2yK_rrE$>"
        +UPSTREAM_CHECK_REGEX =
        "releases/tag/menulibre-(?P<pver>\d+(\.\d+)+)"


    Have you thought about using the github-releases class?
    
https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/github-releases.bbclass
    
<https://urldefense.com/v3/__https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/github-releases.bbclass__;!!AjveYdw8EvQ!bKY-Z8hDPZ1rInc8GaffPbWE8O3W58q7MPuTzwRhNqbrXy1RUExnM7ujmUTbNXw-L7ZA15JdzRmFLAvPgmRlN7VVUaMq$>

    It doesn't work because the website address doesn't conform to the
    format in github-releases.bbclass:

    --2025-11-10 16:04:14--
    https://github.com/menulibre/menulibre/releases/
    
<https://urldefense.com/v3/__https://github.com/menulibre/menulibre/releases/__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4UigtnL$>
    Resolving github.com
    
<https://urldefense.com/v3/__http://github.com__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4dPIRYv$>
    (github.com
    
<https://urldefense.com/v3/__http://github.com__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4dPIRYv$>)...
    20.205.243.166
    
<https://urldefense.com/v3/__http://20.205.243.166__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk1TxdIep$>
    Connecting to github.com
    
<https://urldefense.com/v3/__http://github.com__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4dPIRYv$>
    (github.com
    
<https://urldefense.com/v3/__http://github.com__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4dPIRYv$>)|20.205.243.166
    
<https://urldefense.com/v3/__http://20.205.243.166__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk1TxdIep$>|:443...
    connected.
    HTTP request sent, awaiting response... 404 Not Found
    2025-11-10 16:04:14 ERROR 404: Not Found.

    INFO: Current version: 2.4.0
    INFO: Latest version:


    There is no https://github.com/menulibre/menulibre/releases/
    
<https://urldefense.com/v3/__https://github.com/menulibre/menulibre/releases/__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugk4UigtnL$>
    , but https://github.com/bluesabre/menulibre/releases
    
<https://urldefense.com/v3/__https://github.com/bluesabre/menulibre/releases__;!!AjveYdw8EvQ!dHTbQ7Kp14mZBv7gZKyZkT0Yhc5H0VJqyfn0nlF4K9GWBbHROi76tYsjRpFNjE8OLXHeuZEt3O-ICfIpm7ugkzVr9lqV$>


You can maybe override GITHUB_BASE_URI and get the UPSTREAM_CHECK_* variable "for free"?

Besides GITHUB_BASE_URI, UPSTREAM_CHECK_REGEX also needs to be overriden because it also doesn't match the regex in the class. This means that we still need to add two more lines of modification even if we inherit the bbclass. I don't think this makes any sense.


//Yi



    //Yi

        +
         do_compile[noexec] = "1"

         do_install:append() {
-- 2.34.1




-- Yoann Congal
    Smile ECS



--
Yoann Congal
Smile ECS
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#121458): 
https://lists.openembedded.org/g/openembedded-devel/message/121458
Mute This Topic: https://lists.openembedded.org/mt/116187911/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to