Hello Otavio, On Wed, Nov 18, 2009 at 2:09 PM, Otavio Salvador <[email protected]> wrote: > On Tue, Nov 17, 2009 at 10:33 PM, Leon Woestenberg > <[email protected]> wrote: >> In OpenEmbedded we used squashfs 4.0 with external patch for LZMA >> compression support. In the meantime, squashfs has mainlined LZMA >> support in its CVS version. >> >> This patches switches to the upstream squashfs-tools and modifies >> bitbake.conf to match the slightly different arguments to mksquashfs. > > I agree with the move to mainline version however your recipe changes > might need some improvement. You don't use the lzma recipe available > in OE and instead grab it again ... IMO this is wrong since it > duplicates the lzma source and also make more difficult to us to > "share" fixes. > Yes, I noticed this.
However, this is *exactl*y how the squashfs author designed his integration of LZMA; simply referring to a specific extracted archive of the LZMA SDK. (consider this is a lazy man's way of static linking) > Besides that I think it is ok. Can you fix it and send a new patch for > review? > I will not fix it. Instead I will contact the squashfs author to ask if he want to consider the neat approach (if of course LZMA provides this). In the meantime, should I apply the patch as-is? Regards, -- Leon _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
