Am Friday, 15. January 2010 schrieb Petr Štetiar:
> Christian Rüb <[email protected]> [2010-01-15 12:03:38]:
> 
> > > > On Friday, 15. January 2010 09:22:28 Koen Kooi wrote:
> > > Apart from it not being in git-format-patch format, yes.
> > 
> > Actually I used git format-patch (with option -p to not generate stats - do
> > you want stats) to create the patch...
> 
> But I think, that Koen meant it isn't in format he can push. Would be good to
> read [1], [2] and search throught mailing list archives for other patches as
> example. And it's missing Signed-off line.
> 
> -- ynezz
> 
> 1. http://wiki.openembedded.net/index.php/GitPhraseBook#Commit_Message
> 2. http://wiki.openembedded.org/index.php/Commit_Policy

Thanks for this. I will prepare a better commit message for the patch. I have 
already made a new one with git format-patch.
I cleaned the tree afterwards and tried to apply my patch, it does work but 
complains about many whitespace errors, also a build afterwards worked.
The whitespace errors come from the patches within the patch. Is this OK, or 
shall/can I do anything about this before submitting?

Cheers,
 Christian

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to