2010/1/17 Eric Benard <[email protected]>: > quoting Koen Kooi : Please don't set variables to the current default > value, but leave them out. We had tons of problems with vars getting > copy/paste where the default changed and we had to manually fix those > (e.g. efl.bbclass still pokes needlessly at PACKAGES). > > Signed-off-by: Eric Benard <[email protected]> > --- > docs/usermanual/chapters/recipes.xml | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/usermanual/chapters/recipes.xml > b/docs/usermanual/chapters/recipes.xml > index cad1d80..30364c0 100644 > --- a/docs/usermanual/chapters/recipes.xml > +++ b/docs/usermanual/chapters/recipes.xml > @@ -323,9 +323,9 @@ mv fixed.recipe.bb myrecipe.bb</screen></para> > then the default value of "r0" is used.</para> > > <para><note> > - <para>It is good practice to always define PR in your recipes, even > - for the <emphasis>"r0"</emphasis> release, so that when editing the > - recipe it is clear that the PR number needs to be updated.</para> > + <para>As PR is set to "r0" as a default, it must not be defined at > the > + creation of the recipe. When editing the recipe for the first time, > the > + PR variable must be defined to "r1".</para> > > <para>You should always increment PR when modifying a recipe. > Sometimes this can be avoided if the change will have no effect on the > -- > 1.6.3.3
Personally (having forgotten to bump PR once or twice), I'm in favour of keeping the recommendation of setting PR = "r0" as good practice in a recipe. Apart from the good practice, it also might help a little bit to give PR a standard location. Frans. _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
