So maybe you should not submit the patch... I would create the recipe as gpsd started up in init.d using a control socket. But from there on i don't know how machine/gps-device specific options should be integrated. Should they be packed into a new recipe, i.e. gpsd-device-....? And if, how if not thorugh defaults or init.d?
regards, Michael 2010/1/23 Koen Kooi <[email protected]>: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 23-01-10 12:08, Michael Lippautz wrote: >> Since a few parts of the .inc are quite confusing I didn't want to >> touch it too much. >> >> Ofc we can start gpsd using a control socket. >> >> How should we then solve the problem concerning the different devices? >> We would still need an init script that adds gps hardware to gpsd via >> the socket and additional packages for different devices providing a >> hardware file (containing the path) ? > > I have no strong opinion on that, it's just that machine specific > initscripts (vs machine specific /etc/default/foo) are just evil :) > >> I am open for suggestions since an I really want to update this. >> (Future gpsd will remove the current API to provide additional gps >> devices support) > > My remarks had nothing to do with your patch (which looks fine, btw), it > just triggered a memory about *#(@*(@ gpsd-conf. > > regards, > > Koen > > >> Regards, >> Michael >> >> 2010/1/23 Koen Kooi <[email protected]>: >> Speaking of GPSD, should we make the default config use a control socket >> instead of hardcoding ttyS3? >> >> regards, >> >> Koen >> >> On 22-01-10 22:58, Michael Lippautz wrote: >>>>> >>>>> Signed-off-by: Michael Lippautz <[email protected]> >>>>> --- >>>>> recipes/gpsd/gpsd.inc | 9 ++++++--- >>>>> recipes/gpsd/gpsd_2.38.bb | 4 +++- >>>>> 2 files changed, 9 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/recipes/gpsd/gpsd.inc b/recipes/gpsd/gpsd.inc >>>>> index a917fbe..5efbe2a 100644 >>>>> --- a/recipes/gpsd/gpsd.inc >>>>> +++ b/recipes/gpsd/gpsd.inc >>>>> @@ -5,12 +5,14 @@ LICENSE = "GPL" >>>>> DEPENDS = "dbus-glib ncurses python" >>>>> PROVIDES = "virtual/gpsd" >>>>> >>>>> +INC_PR = "r0" >>>>> + >>>>> EXTRA_OECONF = "--x-includes=${STAGING_INCDIR}/X11 \ >>>>> --x-libraries=${STAGING_LIBDIR} \ >>>>> --enable-dbus \ >>>>> - --enable-python" >>>>> +" >>>>> >>>>> -SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz \ >>>>> +SRC_URI = "http://download.berlios.de/gpsd/gpsd-${PV}.tar.gz;name=gpsd \ >>>>> file://gpsd-default \ >>>>> file://gps-hardware \ >>>>> file://gpsd" >>>>> @@ -28,6 +30,8 @@ LDFLAGS += "-L${STAGING_LIBDIR} -lm" >>>>> export STAGING_INCDIR >>>>> export STAGING_LIBDIR >>>>> >>>>> +TARGET_CC_ARCH += "${LDFLAGS}" >>>>> + >>>>> do_compile_prepend() { >>>>> export BUILD_SYS="${BUILD_SYS}" >>>>> export HOST_SYS="${HOST_SYS}" >>>>> @@ -41,7 +45,6 @@ do_install_prepend() { >>>>> >>>>> do_install_append() { >>>>> install -d ${D}/${sysconfdir}/init.d >>>>> - install -d ${D}/dev >>>>> install -m 0755 ${WORKDIR}/gpsd ${D}/${sysconfdir}/init.d/ >>>>> install -m 0755 ${WORKDIR}/gps-hardware >>>>> ${D}/${sysconfdir}/init.d/gps-hardware.default >>>>> install -d ${D}/${sysconfdir}/default >>>>> diff --git a/recipes/gpsd/gpsd_2.38.bb b/recipes/gpsd/gpsd_2.38.bb >>>>> index 06a5fe7..7c7a477 100644 >>>>> --- a/recipes/gpsd/gpsd_2.38.bb >>>>> +++ b/recipes/gpsd/gpsd_2.38.bb >>>>> @@ -1,5 +1,7 @@ >>>>> require gpsd.inc >>>>> >>>>> -PR = "r2" >>>>> +PR = "${INC_PR}.1" >>>>> # make attempts to link gpspacket.so without waiting for all compiler >>>>> tasks: >>>>> PARALLEL_MAKE = "" >>>>> + >>>>> +EXTRA_OECONF += " --enable-python " >> >>> >>> > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >>> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.5 (Darwin) > > iD8DBQFLWwKZMkyGM64RGpERAi5bAJ9oNZzwy8Jrl03IovVdD4Bqw2tIkQCgsW4+ > jq/K97DHKqK4b05yJv+if34= > =33vV > -----END PGP SIGNATURE----- > > > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
