Hello.

Sorry for the delay. Just found that one in patchwork.

On Tue, 2009-11-03 at 14:35, Jaap de Jong wrote:
> Updated.
> Much simpeler now...

Nearly there.

> Suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs

Please prefix the message with the recipe name. Makes it easier to read commit
logs and understand about which recipe they are. Like:

xc3sprog: Add suite of ...

> ---
>  recipes/xc3sprog/xc3sprog_411.bb |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/xc3sprog/xc3sprog_411.bb
> 
> diff --git a/recipes/xc3sprog/xc3sprog_411.bb 
> b/recipes/xc3sprog/xc3sprog_411.bb
> new file mode 100644
> index 0000000..0ffc4dc
> --- /dev/null
> +++ b/recipes/xc3sprog/xc3sprog_411.bb
> @@ -0,0 +1,15 @@
> +# xc3sprog build file
> +LICENSE="GPL"
> +DESCRIPTION="suite of utilities for programming Xilinx FPGAs, CPLDs, and 
> EEPROMs"

Nitpick. Please start with uppercase.

> +HOMEPAGE="http://sourceforge.net/projects/xc3sprog";
> +
> +DEPENDS += "libftdi"
> +
> +SRC_URI = 
> "svn://xc3sprog.svn.sourceforge.net/svnroot/xc3sprog;proto=https;module=trunk"
>  
> +SRCREV = ${PV}
> +
> +S="${WORKDIR}/trunk"
> +PR = "r0"
> +
> +inherit cmake

To sort the the lines in the recipe to look more like others in the repo you can
run it through contrib/oe-stylize.py

If you care to resend the updated patch I'm going to test and apply it.

regards
Stefan Schmidt

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to