On Mon, 22 Feb 2010 10:52:03 +0100 Holger Hans Peter Freyther <[email protected]> wrote:
> On Friday 19 February 2010 11:34:49 Antonio Ospite wrote: > > Signed-off-by: Antonio Ospite <[email protected]> > > --- > > In canadian-sdk.bb ${SDK_SYS} is used as a prefix but I find more logical > > to put it just before the target system info. > > The commit message is so weak I can't figure out a why... and I think you > want > to have the signed-off-by in the commit message too. > The SOB line is in the "void" commit message already, git-am should get it fine. I thought the brief explanation in the subject line was enough, but evidently I was wrong. Maybe using "host system" in the message is ambiguous as well? I'd like to have this patch applied so that we can tell from the toolchain archive name on which _build_host_ (which arch, basically) the toolchain is supposed to be used, an x64-to-armv5te crosscompiler won't work on i686. Finally the annotation wanted to spot out the difference with canadian-sdk which does already what I am talking about, I considered not worth putting such "meta" comments into the commit message. I am getting back to you with a more explicit commit log. Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
pgppiad42ZpoT.pgp
Description: PGP signature
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
