On Fri, 12 Mar 2010 12:16:48 -0800 Khem Raj <[email protected]> wrote:
> On Fri, Mar 12, 2010 at 4:27 AM, Antonio Ospite > <[email protected]> wrote: > > Having a leading dot in DISTRO_VERSION will result in a '-.' string when > > building archive names; this may lead to mistakenly think that something is > > missing in the archive name. > > > > Example: > > minimal-.dev-snapshot-20100216-i686-linux-armv5te-linux-gnueabi-toolchain.tar.bz2 > > ^^ > > > > Remove the leading dot in DISTRO_VERSIONs to avoid such possible > > confusion. > > > > Signed-off-by: Antonio Ospite <[email protected]> > > looks ok to me > Acked-by: Khem Raj <[email protected]> > Thanks Khem, is anyone going to apply this one? Regards, Antonio > > > --- > > Changes since RFC/v1: > > Just strip the leading dot as suggested by Khem Raj. > > > > Thanks, > > Antonio > > > > conf/distro/minimal.conf | 2 +- > > conf/distro/oplinux-uclibc.conf | 2 +- > > conf/distro/oplinux.conf | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf > > index 8e0ae2e..7aa6c58 100644 > > --- a/conf/distro/minimal.conf > > +++ b/conf/distro/minimal.conf > > @@ -11,7 +11,7 @@ > > # NAME and VERSION > > ############################################################################# > > DISTRO_NAME ?= "minimal" > > -DISTRO_VERSION = ".dev-snapshot-${SRCDATE}" > > +DISTRO_VERSION = "dev-snapshot-${SRCDATE}" > > #DISTRO_TYPE = "release" > > DISTRO_TYPE ?= "debug" > > > > diff --git a/conf/distro/oplinux-uclibc.conf > > b/conf/distro/oplinux-uclibc.conf > > index b8617cc..480602b 100644 > > --- a/conf/distro/oplinux-uclibc.conf > > +++ b/conf/distro/oplinux-uclibc.conf > > @@ -21,7 +21,7 @@ require conf/distro/include/sane-srcdates.inc > > # Header > > # > > DISTRO_NAME = "OPLinux-uClibC" > > -DISTRO_VERSION = ".dev-snapshot-${SRCDATE}" > > +DISTRO_VERSION = "dev-snapshot-${SRCDATE}" > > #DISTRO_TYPE = "release" > > DISTRO_TYPE = "debug" > > > > diff --git a/conf/distro/oplinux.conf b/conf/distro/oplinux.conf > > index 43e8fad..b64477c 100644 > > --- a/conf/distro/oplinux.conf > > +++ b/conf/distro/oplinux.conf > > @@ -25,7 +25,7 @@ require conf/distro/include/sane-srcdates.inc > > # Header > > # > > DISTRO_NAME = "OPLinux" > > -DISTRO_VERSION ?= ".dev-snapshot-${SRCDATE}" > > +DISTRO_VERSION ?= "dev-snapshot-${SRCDATE}" > > #DISTRO_TYPE = "release" > > DISTRO_TYPE = "debug" > > > > -- > > 1.7.0 > > > > > -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
pgpnbsfJaTVGk.pgp
Description: PGP signature
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
