On Fri, Jun 4, 2010 at 5:52 AM, Frans Meulenbroeks < [email protected]> wrote:
> Apologies for not replying to the original message, but that one is > already deleted. > > Just bumped into this after doing a pull. > > A few comments: > > I would suggest if doing something like this that it is announced > somewhat more explictly so people are well aware of it. Since it was > brought as a patch it escaped my attention, and in fact it is not only > a patch but also a change of policy. > Personally, I'd think people should always read any patches to the main classes, including patch.bbclass. Any change to a core class or config file has the potential for large impact, and it would benefit everyone to be aware of those things. That said, I'll be sure to send out an RFC to try to draw more attention to it next time around. > Also I'd like to suggest to complete the change by also updating the > manual, otherwise this could become confusing. > Yes, I know, I intended (and still do intend) to update the manual, but haven't gotten to it yet. I apologize for the delay. > Most recipes are updated, but a few are apparently not. > This is a grep on a git pull of yesterday (or maybe 1.5 day ago): > > fr...@frans:~/workspace/nios2/openembedded.git$ grep -r ";patch" recipes > recipes/m4/m4_1.4.14.bb:SRC_URI += "file://f13-compile.patch;patch=1" > recipes/udev/udev_092.bb:SRC_URI += "file://noasmlinkage.patch;patch=1 \ > recipes/udev/udev_092.bb: file://flags.patch;patch=1 \ > recipes/udev/udev_092.bb: file://udevsynthesize.patch;patch=1 \ > recipes/udev/udev_092.bb: file://arm_inotify_fix.patch;patch=1 > \ > recipes/udev/udev_092.bb: > file://mtd-exclude-persistent.patch;patch=1 \ > recipes/udev/udev_100.bb:SRC_URI += "file://noasmlinkage.patch;patch=1 \ > recipes/udev/udev_100.bb: file://flags.patch;patch=1 \ > recipes/udev/udev_100.bb: > file://mtd-exclude-persistent.patch;patch=1 \ > recipes/udev/udev_097.bb:SRC_URI += "file://noasmlinkage.patch;patch=1 \ > recipes/udev/udev_097.bb: file://flags.patch;patch=1 \ > recipes/ti/matrix-gui_svn.bb: > file://0001-Disable-cursor-override-for-X11.patch;patch=1 \ > recipes/mplayer/mplayer_0.0+1.0rc2.bb: > file://w100-mplayer.patch;patch= \ > I suspect those were due to recent merges and commits after the change, as I'm fairly certain the patches covered the existing ones at that point in time. It's also harmless. The old flags *still work*, they're just deprecated, and will display warnings, along with suggestions of what to use instead. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
