I went ahead and applied this to master. We can always tweak it further, but it's a definite improvement as is, in my opinion.
On Wed, Jun 9, 2010 at 8:08 AM, Chris Larson <[email protected]> wrote: > On Tue, Jun 8, 2010 at 12:40 PM, Ryan Phillips <[email protected]> wrote: > >> We were having problems with wget fetching through our proxy. One of >> the problems stemmed from quoting around the environment variables, >> and the other appears to be from legacy code not calling into >> runfetchcmd within the wget fetcher. > > > Seems fine for the most part. One quick question: Can you explain why > you're escaping the double quotes in your quoting of the env vars, when its > contained in a singled quoted string, not double? Of course, we should > really switch that code over to using subprocess, passing the environment as > a mapping, rather than this sort of shell script emission. > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics > -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
