On Thu, 29 Jul 2010, Eduardo Lima (Etrunko) wrote:

+do_unpack_append() {
+       bb.build.exec_func('do_move_files', d)
+}
+
+do_move_files() {
+       mv "${WORKDIR}/cmakeconfig.h.cmake" "${S}"
+       mv "${WORKDIR}/CMakeLists.txt" "${S}"
+}
+

Instead of custom do_unpack_append I simply put a OECMAKE_SOURCEPATH =
"../", which makes the recipe cleaner, IMHO. But that's just the
opinion of a newbie in the OE lands. :)

I agree your approach makes the recipe simpler. On the other hand, my approach keeps WORKDIR cleaner. (Yeah, who cares about WORKDIR. But having sources in a single dir instead of all-over-the-place mixing with logs and package seems nicer to me.)

But overall it's not much of a difference IMHO, so as the submitted version works, I'd prefer to keep it. If there are strong preferences for OECMAKE_SOURCEPATH then I have n/p with changing that, though.

Regards,

David
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to