Am Mittwoch, den 25.08.2010, 22:44 +0600 schrieb Anatoly Shipitsin: Maybe change the commit summary to
sysvinit_2.86.bb: make sysvinit-utils compatible with upstart
> From: Norguhtar <[email protected]>
Where does that name come from? This line will be taken as the author
information (`git log`, `git log --pretty=fuller`) because it differs
from your name in the email address. (That is the reason the From: line
got added in the first place.)
Being different from your other message, you should decide using one of
them, because it makes it easier to look at the statistics having you
turn up as one person only.
> * move shutdown to sysvinit package
> * move killall5 to sysvinit-utils
> * change PR = "r59"
Next time, »• bump PR« or »• increase PR« is enough.
Reading your commit message a more elaborate explanation is missing what
the problem is with current `sysvinit-utils`. The commit summary says it
has something to do with upstart, but explanation, of why it is a
problem, would make it a perfect commit message.
This is in my opinion even more important than the information you
provided, since I could look those up. But I cannot grasp the “why”.
This would make reviewing and judging and therefore committing your
patch much easier and faster.
> Signed-off-by: Anatoly Shipitsin <[email protected]>
Otherwise I did not find anything else reviewing this. I did not test it
though.
Reviewed-by: Paul Menzel <[email protected]>
[…]
If you decide to adapt the commit summary/message and to send a v4, you
can add my Reviewed-by line manually.
I do not have commit rights. So if nothing happens during the next two
days, please join the IRC channel and bug the people there – most of
them have commit rights – to apply and commit your patch.
Thanks,
Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
