On Mon, Feb 3, 2025 at 11:59 AM Peter Marko via lists.openembedded.org
<peter.marko=siemens....@lists.openembedded.org> wrote:
>
> I have explicitly added comment to the recipe to keep the reference to MIT 
> license.
>

That is good.

> And as the commit message explains, license file is not distributed in python 
> module, so there is nothing to link to.
>

I think we can add the header of utf8_range/utf8_range.c to
LIC_FILES_CHKSUM trimming the content to checksum just the header
as Tim said, will make it more robust for future changes.

>
>
> Peter
>
>
>
> From: Tim Orling <ticot...@gmail.com>
> Sent: Monday, February 3, 2025 20:47
> To: Marko, Peter (FT D EU SK BFS1) <peter.ma...@siemens.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-python][PATCH v2 7/9] python3-protobuf: add MIT to 
> license
>
>
>
>
>
>
>
> On Mon, Feb 3, 2025 at 10:23 AM Peter Marko via lists.openembedded.org 
> <peter.marko=siemens....@lists.openembedded.org> wrote:
>
> From: Peter Marko <peter.ma...@siemens.com>
>
> utf_range is MIT licensed.
> Although the LICENSE file is not distributed in python protobuf,
> this can be read in c++ protobuf recipe where all files are present.
>
>
>
> Shouldn’t we include a beginline/end line clause for at least one source 
> file? Otherwise only this commit log explains why MIT is present. We want 
> traceability fir our future forgetful selves.
>
>
>
> Signed-off-by: Peter Marko <peter.ma...@siemens.com>
> ---
>  .../recipes-devtools/python/python3-protobuf_4.25.3.bb        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-python/recipes-devtools/python/python3-protobuf_4.25.3.bb 
> b/meta-python/recipes-devtools/python/python3-protobuf_4.25.3.bb
> index b92f91b714..fb95340f7b 100644
> --- a/meta-python/recipes-devtools/python/python3-protobuf_4.25.3.bb
> +++ b/meta-python/recipes-devtools/python/python3-protobuf_4.25.3.bb
> @@ -1,8 +1,8 @@
>  DESCRIPTION = "Protocol Buffers"
>  HOMEPAGE = "https://developers.google.com/protocol-buffers/";
>  SECTION = "devel/python"
> -
> -LICENSE = "BSD-3-Clause"
> +# MIT license is from utf8_range
> +LICENSE = "BSD-3-Clause & MIT"
>  LIC_FILES_CHKSUM = 
> "file://PKG-INFO;beginline=8;endline=8;md5=53dbfa56f61b90215a9f8f0d527c043d"
>
>  inherit pypi setuptools3
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#115257): 
https://lists.openembedded.org/g/openembedded-devel/message/115257
Mute This Topic: https://lists.openembedded.org/mt/110976773/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to