On Fri, Sep 10, 2010 at 11:55:13AM -0700, Chris Larson wrote: > On Fri, Sep 10, 2010 at 11:50 AM, Denys Dmytriyenko <[email protected]> wrote: > > > >> I'd agree with this quite strongly. I'm generally pretty careful to let > > >> others review the changes from my coworkers, to avoid any bias. > > > > Not to point any fingers, but mishaps happen and numerous reverts would be > > a > > living proof of that in the repository... :) Nobody's perfect. > > > Mishaps have nothing to do with this, nor does being perfect, or reverts. > You're missing the point entirely here. The point is, if the only people > who acked a patch are from the same company as the person who wrote it, they > can't be considered to have been entirely unbiased in their review of it.
Chris, Didn't mean to offend you by that joke, sorry about that. And I didn't mean you specifically, as we all had our share of revert... But in the second, important :) part of my message, which you chose to ignore and remove from the reply, I did acknowledge the problem and agreed to the proposed changes. But, as I also mentioned, there should be a failsafe mechanism to eventually accept changes, if nobody cared to comment or strongly object, after the review period is over. -- Denys _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
