Hello Paul,

thank you for your patch. Could you please add the recipe name to the
beginning of the commit summary as demanded by the commit policy
[1]. ;-)

I will. This one actually was my first patch (I made the same mistake in my second patch - the wvstreams dbus issue - which I already fixed), so don't worry, my commit summary naming should be OK for future patches :)

This adds include/linux/falloc.h to the list of files
exported by the kernel to the C library.
The include file is required for building e.g. a recent util-linux-ng
against 2.6.24.

it looks like the same fix was committed upstream [3] in March 2008 [4].
Since the Linux kernel 2.6.24 was released in January 2008 this fixed
should be present in all Linux kernels>= 2.6.24.

It is present in all kernels > 2.6.24. It's actually in the changelog for 2.6.25: <http://ftp.halifax.rwth-aachen.de/kernel/linux/kernel/v2.6/ChangeLog-2.6.25> (search the page for "falloc.h").

But we're stuck with 2.6.24 :-/

If you sent a patch iteration, please add that information to the commit
message.

What's a patch iteration?

Signed-off-by: Thilo Fromm<[email protected]>
---
  .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
  .../linux-libc-headers_2.6.24.bb                   |    1 +
  2 files changed, 11 insertions(+), 0 deletions(-)
  create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch

diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch 
b/recipes/linux-libc-headers/files/export_falloc_h.patch
new file mode 100644
index 0000000..5860e88
--- /dev/null
+++ b/recipes/linux-libc-headers/files/export_falloc_h.patch

Could you please add a patch header as suggested in [2].

I suppose you're referring to a line like

upstream: OE-only

? As this patch is not supposed to go upstream (because it's already there) - do you think this is still necessary?

Otherwise I'd just adjust the patch summary and then resubmit the patch as v2.

Regards,
Thilo

--
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:[email protected]
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to