On Sat, Oct 23, 2010 at 11:15 AM, Koen Kooi <[email protected]>wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 23-10-10 19:03, Chris Larson wrote: > > On Sat, Oct 23, 2010 at 6:45 AM, Koen Kooi <[email protected]> wrote: > > > >> From: Koen Kooi <[email protected]> > >> > >> Signed-off-by: Koen Kooi <[email protected]> > >> > >> --- > >> classes/module.bbclass | 191 > >> ++++++++++++++++++++++++++++++++++++++++++++++- > >> 1 files changed, 186 insertions(+), 5 deletions(-) > >> > > > > > > How about moving the common functions into oe.module or oe.package and > using > > them from module.bbclass and kernel.bbclass? > > I thought about that, but that needs more work :( We need to pass in a > different path to System.map, use PN as metapackage name, use a > different blacklist, etc. > That requires a lot more python skill than I currently have. > > Apart from the horrendous code duplication, how does this look? It seems > to do the right thing for the recipes I tested with :) > Looks reasonable otherwise, can always consolidate in a second pass later on. Acked-by: Chris Larson <[email protected]> -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
