Am Dienstag, den 26.10.2010, 08:38 +0200 schrieb Frans Meulenbroeks: > 2010/10/26 dbatzle <[email protected]>:
The commit summary should start with the recipe name as suggested by the commit policy [1]. > > Signed-off-by: dbatzle <[email protected]> I guess a real name would be preferred. But if you want to stay anonymous that is alright too I guess. > > --- > > recipes/bullet/bullet.bb | 18 ++++++++++++++++++ > > 1 files changed, 18 insertions(+), 0 deletions(-) > > create mode 100644 recipes/bullet/bullet.bb > > > > diff --git a/recipes/bullet/bullet.bb b/recipes/bullet/bullet.bb > > new file mode 100644 > > index 0000000..d28734f > > --- /dev/null > > +++ b/recipes/bullet/bullet.bb > > @@ -0,0 +1,18 @@ > > +DESCRIPTION = "Bullet Physics Library" > > +LICENSE = "Zlib" > > + > > +PR = "r1" > > A recipe should start at r0. > Can you also add HOMEPAGE (and maybe some more of the header fields) > > > +SRCREV="2218" > > +PV="2.77+svnr${SRCPV}" > > + > > +#SRC_URI = "file:///home/David/gamestuff/bullet-2.75" > > suggest to remove the line above > > > +SRC_URI = "svn://bullet.googlecode.com/svn;module=trunk;proto=http" > > + > > +#If you want to build the demos you will have to have xlib and glut > > installed. > > +#Then set BUILD_DEMOS, BUILD_EXTRAS, and USE_GLUT to ON > > + > > +EXTRA_OECMAKE="-DBUILD_DEMOS:BOOL=OFF -DBUILD_EXTRAS:BOOL=OFF > > -DUSE_GLUT:BOOL=OFF -DBUILD_SHARED_LIBS:BOOL=ON" > > + > > +inherit cmake > > + > > +S = "${WORKDIR}/trunk" > > -- > > 1.6.0.6 I agree with Frans’ suggestions. You can also run `oe-stylize.py` [2] if you have not done so already. Please do not forget to update the patch queue [3]. Thanks, Paul [1] http://wiki.openembedded.org/index.php/Commit_Policy [2] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/contrib/oe-stylize.py [3] http://wiki.openembedded.org/index.php/Patchwork
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
