According to the commit policy [1] a colon goes after the changed file.
[PATCH] metano.conf: add IMAGE_BASENAME to IMAGE_NAMEAm Donnerstag, den 11.11.2010, 22:24 -0200 schrieb angelox_123: Sorry for nitpicking the commit message. Since you are going to send further patches, I think it is beneficial since you can consider these rules in the future. The commit messages of Git are normally very well written and can serve as an example [2]. Also beware that I am no native speaker either so my remarks could be wrong. > * Added IMAGE_BASENAME on Metano Distro configuration file on IMAGE_NAME Add IMAGE_BASENAME to IMAGE_NAME in Metano’s configuration file. (Use present tense in the commit message.) > * This will help we to identify the names of our images :) s/we/me/ > * By: angelox_123 (from IRC #metano_linux),developer and mainteiner of > Metano Distro maint*a*iner > Signed-off-by: angelox_123 <[email protected]> Since non of your patches have been pushed yet (?), is it on purpose you are using your IRC nick name in the SOB line? I would prefer your real name but it is no requirement as far as I know. For the statistics you should decide what you are going to use and stick to it. > --- > conf/distro/metano.conf | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/conf/distro/metano.conf b/conf/distro/metano.conf > index 9bab8d9..ae29e7d 100644 > --- a/conf/distro/metano.conf > +++ b/conf/distro/metano.conf > @@ -56,7 +56,7 @@ IPKG_VARIANT = "opkg" > ############################################################################# > # IMAGES CONFIGURATION > ############################################################################# > -IMAGE_NAME = "Metano_Linux-PD.Edition-${DISTRO_VERSION}-${MACHINE}" > +IMAGE_NAME = > "Metano_Linux-PD.Edition-${IMAGE_BASENAME}-${DISTRO_VERSION}-${MACHINE}" > > CACHE = "${TMPDIR}/cache/${LIBC}/${MACHINE}" > DEPLOY_DIR ?= "${TMPDIR}/deploy/${LIBC}" > @@ -119,12 +119,9 @@ DISTRO_EXTRA_RRECOMMENDS += " \ > kernel-module-ext2 \ > kernel-module-ext3 \ > kernel-module-af-packet \ > - mplayer \ > alsa-lib \ > alsa-utils \ > nano \ > - gpe-filemanager \ > - gpe-mini-browser \ > ${XSERVER} \ > avahi-daemon \ > avahi-autoipd \ The removal of these programs are not mentioned in the commit message and should be in a separate patch. You can use `git rebase -i HEAD~4` and `git add --patch` to split this up. Thanks, Paul [1] http://wiki.openembedded.org/index.php/Commit_Policy [2] http://git.kernel.org/?p=git/git.git;a=log
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
