Hello Andreas, I can't answer your technical questions regarding the recipe, because I'm not using a clutter/gtk/x11 based distro. I'd like to comment the rest of your mail, though.
On 02/01/2011 08:02 PM, Andreas Mueller wrote: > it surprised me to see that Koen committed a new recipe for clutter 1.4.2. As > you might know I was also working on this and sent some pre-release version > here of this (1). What makes me not running in happy mode: > > - Many of my previous patches were rejected first because of some commit > message. Here we read 'clutter: add 1.4.2' - cool. Which tests were performed? In general, contrary to patches which modify existing files, I think that patches adding new recipes don't need a detailed commit message. Still, a message should describe the content of a commit in a suitable and understandable way. In my opinion, "<name>: add <version>" sufficiently describes any new recipe, unless there's anything special about it. In this case, I would have preferred glib-gettextize getting mentioned, which was added to clutter.inc. > Please don't tell me I am invited to change this situation: Many patches > send by non-commit guys are nit-picked at least for commit message - and then > I read 'clutter: add 1.4.2' for a recipe breaking lots of others. Well, shit happens, unfortunately. Hopefully it was tested and worked in a different environment. Bug reports like this are needed to make it work for as many environments as possible. I've added Koen to CC to decrease the chance that your bug report gets lost without Koen noticing. I think he didn't mean to offend you in any way with his commit. Nit-picking happens frequently, and personally I prefer getting negative feedback over no feedback at all. Usually it's not very hard to address the complaints, although it can be very frustrating to get only a short comment on something you've put a lot of time into. My guess is that this has occurred at least once to everybody who contributed to open source projects. > Sorry for this, but to me the this should have been a hobby for having fun - > but at the moment it's far from So let's try to regain some fun after this problem gets solved! You shouldn't take it personally. > Andreas > > (1) > http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-January/029260.html Regards, Andreas _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
