Am Sonntag, den 08.05.2011, 10:02 +0100 schrieb Phil Blundell: > On Sun, 2011-05-08 at 08:56 +0200, Paul Menzel wrote: > > Am Samstag, den 07.05.2011, 17:59 -0700 schrieb Khem Raj: > > > On (04/05/11 11:56), Bob Foerster wrote: > > > > You can be more specific in the commit summary. > > > > do not override `DEPENDS` for x86 > > > > > > The recipe intended to add "yasm-native" to the dependencies on x86, > > > > Use present tense. s/intended/intends/ > > If this is talking about the former, erroneous behaviour (which is > corrected by this patch) then the past tense is correct.
I thought in minutes or proceeding always the present tense is used. The
recipe behaves incorrectly until the patch is applied. But it is not
very important.
> > > > -DEPENDS_x86 = "yasm-native"
> > > > +DEPENDS_append_x86 = "yasm-native"
> > > ^
> > > you need a space
> >
> > You should also be able to use +=, should not you?
>
> No, += doesn't work with overrides. "DEPENDS_x86 +=" would do the same
> wrong thing as the original "DEPENDS_x86".
Thank you for the clarification. Is for example `RDEPENDS_${PN}` also an
override? If yes, then looking at
$ git grep 'DEPENDS_'
returns a lot of incorrect usages.
Thanks,
Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
