Am Montag, den 16.05.2011, 21:10 -0400 schrieb Christian Betz: > Signed-off-by: Christian Betz <[email protected]> > --------------------------------------------------------- > I'm sorry I missed the part about officially signing off.
No problem. This has happened to all of us. I committed your patch in [1]. Please update the state in the patch queue [2]. > Would you mind telling me the sequence of git format-patch and git > send-email that you typically use? > > This is what I plan to do next time > > git format-patch -s 2b621ed98259fa87b2e7ad05d4787d2dbf618608 > git send-email --annotate 0001-fix-something.patch > > I will put the commit message as the subject and then detail why the > fix is needed in my editor in annotate mode. The subject should just contain the summary and the body further information [3]. So what you wanted to write into annotate you should put that into the commit message, i. e., when you run `git commit`. So an example work flow could be the following. git commit -s # quick note if you are in a hurry git commit --amend -s # to improve the commit message git rebase -i HEAD~20 # 20 is an example. This way you can reformat/reorder/edit committed patches. git format-patch -1 -s # -1 takes the last commit git send-email 0001-fix-something.patch # You do not need `--annotate` if you formatted and improved everything above. `-s` is only needed once in that series but it is ignored if the Signed-off-by line is already present. > Or maybe there is an official wiki document you (someone) can point me to? I found [4] and [5]. The manual pages are also very elaborate and accessible using `git help yourcommand`, e. g., `git help format-patch`. Thanks, Paul [1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e0d2de398e156fbdc913cc4decf75c357fcf2b33 [2] http://openembedded.org/index.php/Patchwork [3] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032692.html [4] http://openembedded.org/index.php/Git [5] http://en.opensuse.org/Git
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
