Am Donnerstag, den 30.06.2011, 12:22 +0200 schrieb Steffen Sledz:

ppp_2.4.5: remove `DP = "-1"`

is a more appropriate and precise commit summary in my opinion.

> Oe-core is using 2.4.5 and it works OK there.
> 
> Signed-off-by: Steffen Sledz <[email protected]>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 2b6b6f7..86d5ae5 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/";
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
>  PR = "r1"
> -# Not well tested
> -DEFAULT_PREFERENCE = "-1"
>  
>  PARALLEL_MAKE = ""

I am getting the following warning when building the recipe with
`minimal{,-uclibc}` which I do not get with PPP 2.4.3.

        NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
        WARNING: the following files were installed but not shipped in any 
package:
        WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
        WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so

Could you fix this in a separate patch before committing this patch?

With the points above fixed/done this patch is

Acked-by: Paul Menzel <[email protected]>


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to