Dear Joel,
Am Dienstag, den 05.07.2011, 20:27 -0500 schrieb Joel A Fernandes:
^
• Is in your Name a dot missing after the second name?
• In the commit summary no full stop at the end is used according to the
new commit guidelines.
> This script flashes the NAND of a beagleboard if it exists, and if there is a
> valid image to flash.
If you capitalize NAND you could also write BeagleBoard.
> Signed-off-by: Joel A Fernandes <[email protected]>
> ---
> .../beagleboard/beagleboard-test-scripts_git.bb | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/beagleboard/beagleboard-test-scripts_git.bb
> b/recipes/beagleboard/beagleboard-test-scripts_git.bb
> index be0d059..237d8d6 100644
> --- a/recipes/beagleboard/beagleboard-test-scripts_git.bb
> +++ b/recipes/beagleboard/beagleboard-test-scripts_git.bb
> @@ -3,10 +3,10 @@ DESCRIPTION = "BeagleBoard test scripts"
> HOMEPAGE = "http://beagleboad.org/support";
> PR = "r2"
Since the package content changes you have to increase the number.
> -SRC_URI =
> "git://gitorious.org/beagleboard-validation/scripts.git;protocol=git \
> +SRC_URI =
> "git://gitorious.org/~joelf/beagleboard-validation/validation-scripts.git;protocol=git
> \
> "
>
> -SRCREV = "473dd2ab20d866be6168c9f992c2c9e74e485c9d"
> +SRCREV = "${AUTOREV}"
In OE it is not wanted to use `AUTOREV`. I do not know though how you
can specify a revision for each repository.
> S = "${WORKDIR}/git"
>
> do_install() {
> @@ -28,4 +28,7 @@ do_install() {
> for i in ${TEST_FILES}; do
> install -m 0755 ${S}/${i} ${D}/${bindir}
> done
> + # Add script to flash the NAND if it exists and if there is a valid image
> to flash on bootup.
• After »Add a space can be removed.
• »on bootup« is not clear to me. Does the BB have to be rebooted and
then the image is flashed?
> + install -d ${D}/${sysconfdir}/rc5.d/
> + install -m 0755 ${S}/flashing/flash-fs.sh
> ${D}/${sysconfdir}/rc5.d/S99flashfs
> }
Thanks,
Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
