Hi Paul, Thanks for your comments. Your suggestion works and is much cleaner.
I have submitted a new patch. Thanks, Joel On Sun, Jul 10, 2011 at 8:05 PM, Paul Menzel <[email protected]> wrote: > Dear Joel, > > > Am Samstag, den 09.07.2011, 19:39 -0500 schrieb Joel A Fernandes: > >> > I do not know if the commit summary is correct and if it should be >> > prepended with ?angstrom?. >> >> Why do say that the commit summary is not correct? The conf file being >> patched is for the Angstrom 2011.03 distribution. > > that is why it should be prepended with angstrom like it is done in > other changes to those files. > > $ git log conf/distro/include/angstrom* > >> >> This fixes all the issues noticed earlier with pulseaudio 0.9.15: >> >> * Pulseaudio keeping audio devices busy when run as per-user instance >> >> * Failure of pactl, pacmd etc to connect to the pulseaudio server >> > >> > Please always include links to corresponding list threads if they are >> > available. >> > >> >> Signed-off-by: Joel A Fernandes <[email protected]> >> >> --- >> >> Notes: >> >> * This has to go into the OpenEmbedded 2011.03-maintenance branch as >> >> there is no such configration file in the master branch >> > >> > $ git grep pulse conf/distro >> > >> > conf/distro/include/angstrom-2008-preferred-versions.inc:PREFERRED_VERSION_gst-pulse >> > = "0.9.7" >> > >> > conf/distro/include/angstrom-2008-preferred-versions.inc:PREFERRED_VERSION_pulseaudio >> > = "0.9.15" >> > >> > conf/distro/include/angstrom-2010-preferred-versions.inc:PREFERRED_VERSION_gst-pulse >> > = "0.9.7" >> > >> > conf/distro/include/angstrom-2010-preferred-versions.inc:PREFERRED_VERSION_pulseaudio >> > = "0.9.22" >> > [?] >> > >> > So you your change could actually be applied to master? >> >> I was trying to say that the conf file involved doesn't exist in the >> master branch >> >> >> conf/distro/angstrom-2008.1.conf | 3 +++ >> >> .../include/angstrom-2008-preferred-versions.inc | 2 +- >> >> 2 files changed, 4 insertions(+), 1 deletions(-) >> >> >> >> diff --git a/conf/distro/angstrom-2008.1.conf >> >> b/conf/distro/angstrom-2008.1.conf >> >> index ae1ed4c..7b4f25a 100644 >> >> --- a/conf/distro/angstrom-2008.1.conf >> >> +++ b/conf/distro/angstrom-2008.1.conf >> >> @@ -121,6 +121,9 @@ PREFERRED_VERSION_binutils_avr32 = "2.17" >> >> PREFERRED_VERSION_binutils-cross_avr32 = "2.17" >> >> PREFERRED_VERSION_binutils-cross-sdk_avr32 = "2.17" >> >> >> >> +ANGSTROM_PULSEAUDIO_VERSION = "0.9.15" >> >> +ANGSTROM_PULSEAUDIO_VERSION_armv7a = "0.9.22" >> >> + >> > >> > 1. Where did you find this syntax? >> > >> > $ git grep PULSE conf/distro/ >> > >> > does not find anything in branch master. >> >> Yes, I didn't either because I was the first one to add it. :) There >> are other variables in the same conf file that provide overrides in a >> similar way. Why do you think is the syntax not correct? > > Well, since in my opinion this variable is redundant. Just change the > versions in the file under `/include/`. > >> > 2. Could you add an explanation, why 0.9.22 is not used for everything >> > and only for armv7a. Is that because of commit cce5e648 [1]? >> >> I'm not sure which commit causes a problem, but Koen can explain more. >> >From what I understand, the compiler doesn't support building this >> version of pulseaudio for armv7a. Koen? > > The old Linux kernel in 2008.1 does not support this for non armv7a > according to Koen’s answer. > >> >> PREFERRED_PROVIDER_dbus-glib = "dbus-glib" >> >> PREFERRED_PROVIDER_hotplug = "udev" >> >> PREFERRED_PROVIDER_opkg ?= "opkg" >> >> diff --git a/conf/distro/include/angstrom-2008-preferred-versions.inc >> >> b/conf/distro/include/angstrom-2008-preferred-versions.inc >> >> index b5b524a..e4b8bf1 100644 >> >> --- a/conf/distro/include/angstrom-2008-preferred-versions.inc >> >> +++ b/conf/distro/include/angstrom-2008-preferred-versions.inc >> >> @@ -44,7 +44,7 @@ PREFERRED_VERSION_pango-native = "1.24.4" >> >> #PREFERRED_VERSION_pixman = "0.13.2" >> >> PREFERRED_VERSION_pkgconfig = "0.23" >> >> PREFERRED_VERSION_pkgconfig-native = "0.23" >> >> -PREFERRED_VERSION_pulseaudio = "0.9.15" >> >> +PREFERRED_VERSION_pulseaudio = "${ANGSTROM_PULSEAUDIO_VERSION}" >> >> PREFERRED_VERSION_python-pycairo = "1.8.0" >> >> PREFERRED_VERSION_qt4-tools-native = "${ANGSTROM_QT_VERSION}" >> >> PREFERRED_VERSION_qt4-tools-sdk = "${ANGSTROM_QT_VERSION}" >> > >> > So I would prefer, if you would change the version just in this file and >> > such a patch could go into branch master first. >> >> master doesn't have a conf/distro/angstrom-2008.1.conf so I'm not sure >> how I can create a patch for the master branch? > > The following change in > > /conf/distro/include/angstrom-2008-preferred-versions.inc > > should be enough, should not it? > > PREFERRED_VERSION_pulseaudio = "0.9.15" > +PREFERRED_VERSION_pulseaudio_armv7a = "0.9.22" > >> > Even better would be the following. >> > >> > 1. Package PA 0.9.23 for oe-dev. If I remember correctly I send all >> > patches upstream and it should work for all architectures(?). >> > 2. Prefer PA 0.9.23 for ?ngstr?m and other distributions. >> > 3. Remove older PA versions. >> > 4. Cherry pick these changes into branch 2011.03-maintenance. >> > >> > Joel, do you have time and motivation to do that? >> >> Motivation is there, but time isn't ;). I can make an effort to do >> this at some point though. Thanks, > > As Koen answered, this plan would not work. > > > Thank you for your answers, > > Paul > _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
