I have no problem with it. whatever is easier for review and testing. On Mon, Aug 8, 2011 at 3:08 PM, Jesse Gilles <[email protected]> wrote:
> On Fri, 2011-08-05 at 11:38 -0400, George C. Huntington, III wrote: > > I posted a patch that makes the wrapper script return the error code > > if it > > fails after 5 retries. it is on patchwork. > > http://patches.openembedded.org/patch/7249/ > > It seems like saving the javac script arguments into the ARGS variable > is what broke the old behavior where -bootclasspath '' worked for > building classpath. Putting that part of the script back to the way it > used to be fixes it. > > Do you want to merge this in with your error code return patch? > > --- a/recipes/ecj/files/ecj.in > +++ b/recipes/ecj/files/ecj.in > @@ -1,13 +1,16 @@ > -ARGS=${1+"$@"} > COUNT=5 > END=0 > +RETURNCODE=0 > > while test "${COUNT}" -gt "${END}" > do > - ${RUNTIME} -Xmx1024m -cp ${ECJ_JAR} > org.eclipse.jdt.internal.compiler.batch.Main ${ARGS} > + ${RUNTIME} -Xmx1024m -cp ${ECJ_JAR} > org.eclipse.jdt.internal.compiler.batch.Main ${1+"$@"} > + RETURNCODE=${?} > if test "${?}" -eq "${END}" > then > break > fi > COUNT=$(($COUNT-1)) > done > + > +exit ${RETURNCODE} > > Otherwise, I can submit it as another patch, but it will depend on yours... > > Thanks, > Jesse > > > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
