On Tue, Sep 17, 2013 at 02:55:52PM +0200, Erik Botö wrote:
> Hi,
>
> I just realized this patch does not package all files. The qt5.inc
> only pick up on files three directories "deep", so I have to extend
> this in qtquickcontrols.inc using:
>
> FILES_${PN}-qmlplugins += " \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/qmldir \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qmltypes \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qml \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*.js \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*/qmldir \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qmltypes \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qml \
> ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.js \
> "
>
> I would assume that this is better done in qt5.inc, can't really think
> of any big drawback with having it central instead of per module and I
> guess the decision to go "three deep" was just that it covered the
> modules that recipes was written for at that time. Right?Right, please notice that https://github.com/meta-qt5/meta-qt5/commit/f11b1722e28800c790609d0de9541f6555e1ee5a was merged today and resolves this. You probably didn't know about alternative patch, because it was sitting on github as pull-request and it wasn't sent to oe-devel, contributor is now aware and will send next patches to oe-devel first. Regards, > > Cheers, > Erik > > On Wed, Sep 11, 2013 at 1:19 PM, Erik Botö <[email protected]> wrote: > > Signed-off-by: Erik Botö <[email protected]> > > --- > > recipes-qt/qt5/qtquickcontrols.inc | 3 +++ > > recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++ > > 2 files changed, 8 insertions(+) > > create mode 100644 recipes-qt/qt5/qtquickcontrols.inc > > create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb > > > > diff --git a/recipes-qt/qt5/qtquickcontrols.inc > > b/recipes-qt/qt5/qtquickcontrols.inc > > new file mode 100644 > > index 0000000..63e884e > > --- /dev/null > > +++ b/recipes-qt/qt5/qtquickcontrols.inc > > @@ -0,0 +1,3 @@ > > +require qt5.inc > > + > > +DEPENDS += "qtdeclarative" > > diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb > > b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb > > new file mode 100644 > > index 0000000..fc880d7 > > --- /dev/null > > +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb > > @@ -0,0 +1,5 @@ > > +require qt5-${PV}.inc > > +require ${PN}.inc > > + > > +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81" > > +SRC_URI[sha256sum] = > > "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b" > > -- > > 1.8.1.2 > > > > > > -- > ============================================= > Erik Botö > Senior Software Engineer > Pelagicore AB > Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden > Mobile: +46 (0)76 881 72 03 > E-Mail: [email protected] > ============================================= -- Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
