On 02/14/2014 11:29 AM, Joe MacDonald wrote:
[Re: [oe] [meta-networking] [PATCH] traceroute: filter-out patches dir] On 
14.02.13 (Thu 08:40) Otavio Salvador wrote:

On Thu, Feb 13, 2014 at 1:03 AM, Robert Yang <[email protected]> wrote:


On 01/22/2014 10:21 PM, Otavio Salvador wrote:

On Mon, Jan 20, 2014 at 10:52 AM, Robert Yang <[email protected]>
wrote:

The $(subdirs) contains all the dirs under the ${B}, and this one:

do_unpack[cleandirs] = "${S}/patches"

will create a "patches" dir, then there will be compile errors, filter
out the patches will fix the problem.

Note: poky doesn't have this problem since it separates the ${S} and
${B}

Signed-off-by: Robert Yang <[email protected]>


Couldn't we change it for OE-Core as well? So we avoid having to patch
the build system.


I'm sorry, I don't quite understand what do you mean, this patch didn't
change the build system, it changed the Make.rules.


To be sincere I didn't understand my comment as well ...  don't recall
what I thought... I'd say to ignore it.

Oh.  Heh.  I thought you were proposing a change to oe-core's build
approach that would mean we didn't need to have a patch here to
traceroute to separate $(B) and $(S).  At least that's what I got from
it based on the commit log.  I'm still a bit confused about what's so
different about traceroute's build system that it needs special handling

traceroute uses this:

EXEDIRS := $(filter-out $(INCLUDEDIRS) $(LIBDIRS) $(MODDIRS), $(subdirs))

the "patches" dir will be included in EXEDIRS which will cause errors, so
we need filter out it.

// Robert


...



_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Reply via email to