On Sun, Apr 20, 2014 at 10:54 AM, Jacob Kroon <[email protected]> wrote: > Hi Martin, > > On Sun, Apr 20, 2014 at 12:34 PM, Martin Jansa <[email protected]>wrote: > >> On Tue, Apr 15, 2014 at 07:12:45PM +0200, Jacob Kroon wrote: >> > Fixes the following warning: >> > >> > WARNING: PACKAGE_GROUP is deprecated, please use FEATURE_PACKAGES instead >> >> It's correct patch, but I'm a bit tempted to take this patch after >> branching daisy, because some people are using latest meta-qt5 with >> older oe-core releases and this undoing this change is easy to miss >> (unlike e.g. cmake .bbappends which fail when not updated for correct >> oe-core releases). >> >> What do you think? >> >> > I think I follow you. So the deprecation happened in commit > d703e07ea5056624101e1bc48f10d25b602635e9, 2014-03-07, so I guess only > daisy/master will give the warning. For older oe-core releases with > meta-qt5 master, this patch could silently break stuff I can imagine. So > like you propose, keeping this one for master only, after branching daisy, > seems like a good idea to me.
I prefer to drop the warning in daisy. It is always bad to have warnings during the build and we ought to have it clean. As I said, this will indeed break people but not many people are using this class as this is quite new. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
