On Thursday 14 of August 2014 17:50:04 Martin Jansa wrote: > On Thu, Aug 14, 2014 at 05:45:12PM +0200, Maciej Borzecki wrote: > > On Thursday 14 of August 2014 17:42:20 Martin Jansa wrote: > > > On Thu, Aug 14, 2014 at 05:31:43PM +0200, Maciej Borzecki wrote: > > > > Pinba support requires protobuf-c that is currently only available in > > > > meta-virtualization layer. Make this a selectable feature. > > > > > > There is some protobuf in meta-oe > > > meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb > > > > > > is protobuf-c something else? > > > > Yes. protobuf in meta-oe is a tool (protoc) and a C++ library, protobuf-c > > is a C implementation of the library. > > So shouldn't PACKAGECONFIG contain protobuf-c as well? Indeed, looks like a brain fart on my side :)
> > If yes, then please add comment above PACKAGECONFIG definition that > protobuf-c is in meta-virtualization (so that people don't need to > search commit messages). > > Thanks > > > > > Signed-off-by: Maciej Borzecki <[email protected]> > > > > Signed-off-by: Maciek Borzecki <[email protected]> > > > > --- > > > > > > > > meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb > > > > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index > > > > 30279c2..837eae5 100644 > > > > --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb > > > > +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb > > > > @@ -32,6 +32,7 @@ PACKAGECONFIG[sensors] = "--enable-sensors > > > > --with-libsensors=yes, \> > > > > > > > > --disable-sensors --with-libsensors=no,lmsensors" > > > > > > > > PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \ > > > > > > > > --disable-amqp --with-librabbitmq=no,rabbitmq-c" > > > > > > > > +PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf > > > > protobuf-native"> > > > > > > > > EXTRA_OECONF = " \ > > > > > > > > ${FPLAYOUT} \ -- Maciej Borzęcki Senior Software Engineer Open-RnD Sp. z o.o. www.open-rnd.pl, Facebook, Twitter mobile: +48 telefon, fax: +48 42 657 9079 Niniejsza wiadomość wraz z załącznikami może zawierać chronione prawem lub poufne informacje i została wysłana wyłącznie do wiadomości i użytku osób, do których została zaadresowana. Jeśli wiadomość została otrzymana przypadkowo zabrania się jej kopiowania lub rozsyłania do osób trzecich. W takim przypadku uprasza się o natychmiastowe zniszczenie wiadomości oraz poinformowanie nadawcy o zaistniałej sytuacji za pomocą wiadomości zwrotnej. Dziękujemy. This message, including any attachments hereto, may contain privileged or confidential information and is sent solely for the attention and use of the intended addressee(s). If you are not an intended addressee, you may neither use this message nor copy or deliver it to anyone. In such case, you should immediately destroy this message and kindly notify the sender by reply email. Thank you. -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
