On Wed, 19 Nov 2014 15:56:47 -0500 Joe MacDonald <[email protected]> wrote:
> Thanks for the submission. Just a couple of comments. > > [[oe] [meta-selinux][PATCH] ustr: Change the SRC_URI to upstream and add a > new patch] On 14.11.19 (Wed 15:34) Qian Lei wrote: > > > Official upstream is still Ok, using it first. > > Add a new patch which is applied in Fedora20 > > As these are two unrelated issues, I think two patches would've been > appropriate with 1/2 being the one that updates the SRC_URI and 2/2 > being the c99 patch. > > You should also provide an upstream-status for the C99 patch. As you > say it came from Fedora, odds are it is already submitted upstream, so > 'pending' could be appropriate here, but I don't know. > > Finally, meta-selinux patches should go to [email protected] (cc'd > here), not the openembedded-dev@ list. > > I'm fine with making the changes I described above or you can send out a > new version of the patch/patches if you like. I won't do anything with > it before tomorrow, either way, to give everyone time to have a look. > > -J. Thanks for your reply.It really help me a lot. I'll take your advice and send a new version of patches to yocto soon. Qian Lei -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
