[RE: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7] On 14.11.26 (Wed 03:36) Bian, Naimeng wrote:
> > -----Original Message----- > > From: [email protected] > > [mailto:[email protected]] On Behalf Of > > Alexandru Vaduva > > Sent: Tuesday, November 25, 2014 6:19 PM > > To: [email protected]; Joe MacDonald > > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and > > upgrade to 1.4.7 > > > > It is my opinion that meta-cgl is the place for your patch being the fact > > that > > pacemaker and the rest of the HA cluster resources are available here. > > Thanks. > I confirmed that corosync-1.2.8 and pacemaker are available inside meta-cgl. > > > Also I believe this patch should be available inside the open embedded > > repository. > > > > Actually, I do not know what kinds of recipes meta-openembedded likes to > merge. > In another hand, what kinds of recipes are no good. > (Of course the unmaintained one such as printproto is no good.) > > If there are some rules, would you tell me what's that. > Maybe it's helpful to a newcomer such as me. ^_^ I can't speak for everyone but in all honesty, where I do networking and CGL stuff I see a lot of things that go 'unmaintained' for years and are still perfectly functional and widely used. Time since last commit isn't an immediate disqualifier in my view. That said, as I think was mentioned with some of your other submissions, if you have a recipe for a package that hasn't been maintained in several years, you should expect to be asked "but why?" There may be a very good answer to that that convinces a layer maintainer to integrate your recipe. You just need to be prepared for the question. For what it's worth, that can also apply to brand new packages. :-) > I got some points from the following document, but it's not detailed. > http://www.openembedded.org/wiki/OpenEmbedded-Core#meta-openembedded > > ---------------------------------------------------------------------------------- > meta-openembedded > > For items shared amongst multiple layers that do not fit into OE-Core or > any other > existing layer, there is the meta-oe layer. This exists in a repository, > also called > meta-openembedded, which contains a number of other more focused layers > (meta-efl, > meta-gnome, etc.). This layer will need to be managed carefully over time to > avoid > it turning into just a newer version of OE-classic. > ---------------------------------------------------------------------------------- This last is the crux of the matter, I think. I personally want to avoid collecting a bunch of recipes that aren't regularly used and fall out of date (either with the needs of the community or with the upstream). > Maybe we should update this document, add some suggestions like following. > ---------------------------------------------------------------------------------- > Attention > Please avoid send a patch such as following. > 1. have not been unmaintained by upstream long time > 2. ... ... > ---------------------------------------------------------------------------------- > > > If it would be ok with you I would suggest to have two patches: one sent for > > the OpenEmbedded and one for the meta-cgl. > > If the porting for meta-cgl would not be possible please let me know for > > assuring > > that the patch is ported inside meta-cgl. > > I confirmed that corosync-1.2.8 is available inside meta-cgl now. > I will send the patch for corosync-1.4.7 to meta-cgl later. That is probably best. I have no objection to it being in meta-networking, but I'm not sure it is broadly applicable and if Alex prefers to keep a corosync recipe in meta-cgl, I'm all for that. > > Another extra reason for which I would prefer this patch to be also > > available > > inside meta-cgl would be the extra testing that will be done for it and the > > fact that corosync messaging layer will be used with pacemaker. > > > > Looks good. > And the same question. ^_^ > Would you tell me what kinds of recipes meta-cgl likes to merge. Alex gave you a pointer, I would also say if you're just asking in general, you can have a look at what software packages are used by CGL registered distributions here: http://www.linuxfoundation.org/collaborate/workgroups/cgl/registered-distributions and the specs, linked from the same page, if you really want to dig into it. The stated goal of meta-cgl is to provide a CGL layer for Yocto, so I'd hazard a guess that anything that gets it closer to that goal in a sensible fashion is welcome. -J. > > Regards > Bian > > > > > Thank you, > > Alex Vaduva > > > > -----Original Message----- > > From: [email protected] > > [mailto:[email protected]] On Behalf Of > > Bian, > > Naimeng > > Sent: Tuesday, November 25, 2014 2:29 AM > > To: Joe MacDonald > > Cc: [email protected] > > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and > > upgrade to 1.4.7 > > > > Hi Joe > > > > Thanks for your advices. > > I will look at meta-cgl. > > > > Regards > > Bian > > > > > -----Original Message----- > > > From: Joe MacDonald [mailto:[email protected]] > > > Sent: Tuesday, November 25, 2014 3:40 AM > > > Cc: [email protected] > > > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from > > > openembedded and upgrade to 1.4.7 > > > > > > Hi Bian, > > > > > > [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and > > > upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote: > > > > > > > Signed-off-by: Bian Naimeng <[email protected]> > > > > --- > > > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31 > > > ++++++++++++++++++++++ > > > > .../corosync/files/config-site.corosync | 4 +++ > > > > meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++ > > > > 3 files changed, 47 insertions(+) > > > > create mode 100644 > > > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb > > > > create mode 100644 > > > > meta-oe/recipes-support/corosync/files/config-site.corosync > > > > create mode 100644 > > > > meta-oe/recipes-support/corosync/files/groff.patch > > > > > > This probably belongs in meta-networking (unless there's strong > > > opinion it belongs somewhere else). Did you have a look at what has > > > been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with the > > > recipe to see if there was anything useful there? I know meta-cgl > > > isn't very well publicized yet, but it is in the layer index. If you > > > haven't looked at what's there yet, it may be worth having a look to > > > see if any of it can save you some time. > > > > > > For what it's worth, there does seem to be rather a lot more in > > > meta-cgl and I think at least some of it still applies (eg. the volatiles > > file). > > > > > > > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb > > > > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb > > > > new file mode 100644 > > > > index 0000000..a3b8864 > > > > --- /dev/null > > > > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb > > > > @@ -0,0 +1,31 @@ > > > > +SUMMARY = "The Corosync Cluster Engine and Application Programming > > > Interfaces" > > > > +DESCRIPTION = "This package contains the Corosync Cluster Engine > > > > +Executive, several default ¥ APIs and libraries, default > > > > +configuration > > > files, and an init script." > > > > +HOMEPAGE = "http://corosync.github.io/corosync/"; > > > > + > > > > +inherit autotools pkgconfig > > > > + > > > > +SRC_URI = > > > "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz ¥ > > > > + file://config-site.corosync ¥ > > > > + file://groff.patch ¥ > > > > + " > > > > > > Please remove the tab before space above. > > > > > > > + > > > > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a" > > > > +SRC_URI[sha256sum] = > > > "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8" > > > > + > > > > +LICENSE = "BSD" > > > > > > I think this is actually a BSD-3-Clause license, isn't it? > > > > > > > +LIC_FILES_CHKSUM = > > > "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30" > > > > + > > > > +CONFIG_SITE = "${WORKDIR}/config-site.corosync" > > > > + > > > > +DEPENDS = "groff-native nss" > > > > + > > > > +EXTRA_OECONF += " --enable-nss " > > > > +CFLAGS_append += " -fPIC " > > > > + > > > > +do_compile() { > > > > + DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk > > > '{if(NR==1)print $4}'`/font" > > > > + oe_runmake DESCPATH=${DESCPATH} } > > > > + > > > > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug" > > > > diff --git > > > > a/meta-oe/recipes-support/corosync/files/config-site.corosync > > > > b/meta-oe/recipes-support/corosync/files/config-site.corosync > > > > new file mode 100644 > > > > index 0000000..3472dec > > > > --- /dev/null > > > > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync > > > > @@ -0,0 +1,4 @@ > > > > +ac_cv_func_fnmatch_works=yes > > > > +ac_cv_func_malloc_0_nonnull=yes > > > > +ac_cv_func_realloc_0_nonnull=yes > > > > + > > > > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch > > > > b/meta-oe/recipes-support/corosync/files/groff.patch > > > > > > Can you add a header to this patch please? > > > > > > Thanks. > > > > > > -J. > > > > > > > new file mode 100644 > > > > index 0000000..da1378a > > > > --- /dev/null > > > > +++ b/meta-oe/recipes-support/corosync/files/groff.patch > > > > @@ -0,0 +1,12 @@ > > > > +diff -Nurp corosync-1.3.1.org/man/Makefile.am > > > corosync-1.3.1/man/Makefile.am > > > > +--- corosync-1.3.1.org/man/Makefile.am 2011-04-25 > > > 10:37:50.000000000 +0800 > > > > ++++ corosync-1.3.1/man/Makefile.am 2014-11-24 10:33:36.583426707 > > > +0800 > > > > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html) > > > > +INDEX_HTML = index.html > > > > + > > > > + %.html: % > > > > +- $(GROFF) -mandoc -Thtml $^ > $@ > > > > ++ $(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@ > > > > + > > > > + install-data-local: > > > > + $(INSTALL) -d $(DESTDIR)/${docdir}/html > > > > -- > > > > 1.9.1 > > > > > > > -- > > > -Joe MacDonald. > > > :wq > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > [email protected] > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > [email protected] > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- -Joe MacDonald. :wq
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
