On second though I believe we should keep it as-is. The reason being that once the install is fixed this should fail ideally so we know that this needs to be stripped out of the recipe at the same time.
BR, Awais ________________________________________ From: [email protected] [[email protected]] on behalf of Belal, Awais Sent: Wednesday, December 17, 2014 6:55 PM To: [email protected] Cc: [email protected] Subject: Re: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories Hi Mike, Thanks for the feedback. Do you think if [ -d ${D}/usr/lib ]; then rmdir ${D}/usr/lib fi would be a better solution here? BR, Awais ________________________________________ From: [email protected] [[email protected]] on behalf of Mike Looijmans [[email protected]] Sent: Tuesday, December 16, 2014 1:28 PM To: [email protected] Subject: Re: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories On 12/16/2014 08:26 AM, Belal, Awais wrote: > ping! > > BR, > Awais > > Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: [email protected] Website: www.topic.nl Please consider the environment before printing this e-mail Topic zoekt gedreven (embedded) software specialisten! http://topic.nl/vacatures/topic-zoekt-software-engineers/ ________________________________________ > From: [email protected] > [[email protected]] on behalf of Belal, Awais > Sent: Monday, December 08, 2014 3:42 PM > To: [email protected] > Subject: [oe] [meta-oe][PATCH v2 2/2] mplayer2: cleanup empty directories > > The mplayer "make install" phase leaves an empty > /usr/lib directory seemingly regardless of the setting > of libdir. Remove it to avoid a packaging warning. > > Signed-off-by: Drew Moseley <[email protected]> > Signed-off-by: Awais Belal <[email protected]> > --- > meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb > b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb > index 6b3d120..a68a2ba 100644 > --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb > +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb > @@ -141,4 +141,5 @@ do_install() { > install ${S}/etc/input.conf ${D}/usr/etc/mplayer/ > install ${S}/etc/example.conf ${D}/usr/etc/mplayer/ > install ${S}/etc/codecs.conf ${D}/usr/etc/mplayer/ > + [ -e ${D}/usr/lib ] && rmdir ${D}/usr/lib This will cause the script to fail when someone fixes the install and /usr/lib was not created, because "test -e ${D}/usr/lib" would return failure. > } > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-devel mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
